refactor!: use vim.diagnostic for lsp provider

BREAKING CHANGE: The `diagnostics_exist` utility function now takes an integer containing the diagnostic severity instead of a string. For more info, do `:help vim.diagnostic.severity` in Neovim.

Author: ram02z

USAGE.md

@@ -667,7 +667,7 @@ The git provider also provides a utility function `require('feline.providers.git
 
 The diagnostics and LSP providers all require the Neovim built-in LSP to be configured and at least one LSP client to be attached to the current buffer, else they'll have no output.
 
-The diagnostics provider also provides a utility function `require('feline.providers.lsp').diagnostics_exist(type)` for checking if any diagnostics of the provided type exists. The values of `type` must be one of `'Error'`, `'Warning'`, `'Hint'` or `'Information'`.
+The diagnostics provider also provides a utility function `require('feline.providers.lsp').diagnostics_exist` for checking if any diagnostics exists. You can also optionally provide a `severity` function argument to only check for diagnostics of that severity. The value of `severity` must be one of the Neovim diagnostic API severities (eg: `vim.diagnostic.severity.WARN`). For more info on diagnostic severities, do `:help vim.diagnostic.severity` in Neovim.
 
 ## Themes
 

lua/feline/providers/lsp.lua

@@ -1,23 +1,23 @@
 local M = {}
 
 local lsp = vim.lsp
+local diagnostic = vim.diagnostic
+
+-- Initialize a local table with severity names to prevent having to create a table in every call of
+-- the diagnostic function to improve performance
+local severity_names = { "Information", "Hint", "Warning", "Error" }
 
 function M.is_lsp_attached()
     return next(lsp.buf_get_clients(0)) ~= nil
 end
 
 function M.get_diagnostics_count(severity)
-    local active_clients = lsp.buf_get_clients(0)
-
-    if not active_clients then return 0 end
-
-    local count = 0
-
-    for _, client in pairs(active_clients) do
-        count = count + lsp.diagnostic.get_count(0, severity, client.id)
+    if vim.fn.has("nvim-0.6") == 1 then
+        return vim.tbl_count(diagnostic.get(0, severity and { severity = severity }))
+    else
+        -- TODO: drop this when 0.5 is no longer used
+        return lsp.diagnostic.get_count(0, severity and severity_names[severity])
     end
-
-    return count
 end
 
 function M.diagnostics_exist(severity)
@@ -42,19 +42,19 @@ local function diagnostics(severity)
 end
 
 function M.diagnostic_errors()
-    return diagnostics('Error'), '  '
+    return diagnostics(diagnostic.severity.ERROR), '  '
 end
 
 function M.diagnostic_warnings()
-    return diagnostics('Warning'), '  '
+    return diagnostics(diagnostic.severity.WARN), '  '
 end
 
-function M.diagnostic_hints()
-    return diagnostics('Hint'), '  '
+function M.diagnostic_info()
+    return diagnostics(diagnostic.severity.INFO), '  '
 end
 
-function M.diagnostic_info()
-    return diagnostics('Information'), '  '
+function M.diagnostic_hints()
+    return diagnostics(diagnostic.severity.HINT), '  '
 end
 
 return M