Skip to content

Commit a10642d

Browse files
Use secrets properly
1 parent 2856c1c commit a10642d

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

.github/workflows/docker-description.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ jobs:
1313
- name: Docker Hub Description
1414
uses: peter-evans/dockerhub-description@v2.4.1
1515
with:
16-
username: ${{ secrets.DOCKERHUB_USERNAME }}
17-
password: ${{ secrets.DOCKERHUB_PASSWORD }}
16+
username: ${{ secrets.DOCKER_USERNAME }}
17+
password: ${{ secrets.DOCKER_PASSWORD }}
1818
repository: peterevans/dockerhub-description

.github/workflows/docker.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ jobs:
1616
uses: actions/checkout@v2
1717
- name: build
1818
env:
19+
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
20+
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
1921
VERSION_SHORT: ${{ matrix.version }}
2022
run: |
2123
./build.sh ${{ matrix.version }}
@@ -27,6 +29,8 @@ jobs:
2729
uses: actions/checkout@v2
2830
- name: build
2931
env:
32+
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
33+
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
3034
EXTRA_TAG: stable
3135
VERSION_SHORT: 1.0
3236
run: |
@@ -39,6 +43,8 @@ jobs:
3943
uses: actions/checkout@v2
4044
- name: build
4145
env:
46+
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
47+
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
4248
EXTRA_TAG: latest
4349
VERSION_SHORT: 1.1
4450
run: |

build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ else
5050
fi
5151

5252
# Travis gets rate limited by Docker HUB.
53-
if [[ ${CI:-} == true && -n $DOCKER_PASSWORD && -n $DOCKER_USERNAME ]]; then
53+
if [[ ${CI:-} == true && -n ${DOCKER_PASSWORD:-} && -n ${DOCKER_USERNAME:-} ]]; then
5454
echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
5555
fi
5656

0 commit comments

Comments
 (0)