Erna is producing redundant queries

[jebuss]

With the new fact_conditions package the options

erna/erna/scripts/process_fact_data.py

Lines 64 to 65 in c159f2c

	@click.argument('earliest_night')
	@click.argument('latest_night' )

and

erna/erna/scripts/process_fact_data.py

Line 78 in c159f2c

@click.option('--source', help='Name of the source to analyze. e.g Crab', default='Crab')

are at least redundant, because with a conditions file containing fSourceName and cuts on fNight you could end up with a query like this.

Querying data with conditions: 
fNight >= 20150901 AND 
fNight <= 20160401 AND 
fSourceName = "Crab" AND 
fCurrentsMedMeanBeg < 8 AND fMoonZenithDistance > 100 AND 
fThresholdMinSet < 350 AND fEffectiveOn > 0.95 AND 
fTriggerRateMedian > 40 AND fTriggerRateMedian < 85 AND 
fThresholdMinSet < (14 * fCurrentsMedMeanBeg + 265) AND 
fZenithDistanceMean < 30.5 AND fZenithDistanceMean > 5.5 AND 
fNight >= 20150901 AND 
fNight <= 20160401 AND 
fSourceName = 'Crab'

In some case this might be just redundant. In other cases this might cause contradicting queries and failures is processing that are not easy to debug.

Thus, i'd like to raise the question it we would like to get rid of:

erna/erna/scripts/process_fact_data.py

Lines 64 to 65 in c159f2c

	@click.argument('earliest_night')
	@click.argument('latest_night' )

and

erna/erna/scripts/process_fact_data.py

Line 78 in c159f2c

@click.option('--source', help='Name of the source to analyze. e.g Crab', default='Crab')

in:
https://github.com/fact-project/erna/blob/master/erna/scripts/process_fact_data.py
https://github.com/fact-project/erna/blob/master/erna/scripts/process_fact_data_qsub.py
https://github.com/fact-project/erna/blob/master/erna/scripts/fetch_fact_runs.py

[tarrox]

I think at least making them into options and thus optional would be a good compromise, if you want to keep them. This would also be nice for simple test; if for example you wanted to decrease the timeframe to test if stuff works correctly in your analysis.