-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Currently erna process scripts allow to set the vmem of the qsub command if desired.
Problem is that setting this is useless for java due to the fact that the java command is set with -XX:MaxHeapSize=1024m
( in function assemble_facttools_call
in file erna/utils.py
line 68).
This means if you need more memory for java, setting vmem higher means nothing for the java process.
It is only usefull to the encapsulating python process, which is still useful, but gives the overall wrong impression of how to increase the memory if it is not enough for java. Which is a problem if you need more heap memory for your java problem, like me.
Also it seems that if the heap memory is not enough, it often leads to a heavy slowdown instead of a crash. Which is bad in itself, as it makes error searching a pain as it hides the real problem and makes you look elsewhere.
This needs some kind of fix.
We should either increase the maximum for the heap or there should be a way to set the max java heap memory somehow (Either as a percentage of vmem or directly trough a click option).