Merge pull request #36 from facebookresearch/samvelyan/nle-0.8.0

Bump the MiniHack and NLE versions

Author: samvelyan

minihack/navigation.py

@@ -1,8 +1,8 @@
 # Copyright (c) Facebook, Inc. and its affiliates.
 
 from minihack import MiniHack
+from minihack.envs import register
 from nle import nethack
-from gym.envs import registration
 
 
 MOVE_ACTIONS = tuple(nethack.CompassDirection)
@@ -42,7 +42,7 @@ def __init__(self, *args, des_file: str = None, **kwargs):
         super().__init__(*args, des_file=des_file, **kwargs)
 
 
-registration.register(
+register(
     id="MiniHack-Navigation-Custom-v0",
     entry_point="minihack.navigation:MiniHackNavigation",
 )

minihack/skills.py

@@ -1,7 +1,8 @@
 # Copyright (c) Facebook, Inc. and its affiliates.
+
 from minihack import MiniHack
 from minihack.base import MH_DEFAULT_OBS_KEYS
-from gym.envs import registration
+from minihack.envs import register
 
 
 class MiniHackSkill(MiniHack):
@@ -51,7 +52,7 @@ def __init__(
         super().__init__(*args, des_file=des_file, **kwargs)
 
 
-registration.register(
+register(
     id="MiniHack-Skill-Custom-v0",
     entry_point="minihack.skills:MiniHackSkill",
 )

minihack/tests/test_system.py

@@ -9,10 +9,8 @@
 import minihack  # noqa: F401
 
 START_METHODS = [
-    # TODO uncomment spawn after the next NLE release
-    # m for m in ("fork", "spawn") if m in mp.get_all_start_methods()
     m
-    for m in ("fork")
+    for m in ("fork", "spawn")
     if m in mp.get_all_start_methods()
 ]
 

setup.py

@@ -38,7 +38,7 @@
 
 install_requires = ["numpy>=1.16", "gym"]
 if not os.getenv("READTHEDOCS"):
-    install_requires.append("nle>=0.7.3")
+    install_requires.append("nle>=0.8.0")
 
 extras_deps = {
     "dev": [

version.txt

@@ -1 +1 @@
-0.1.1
+0.1.2