Drop support for python 3.8

rsokl · rsokl · commit 0b125e1893dc · 2025-10-24T12:22:28.000-04:00
diff --git a/.flake8 b/.flake8
@@ -19,4 +19,4 @@ max-line-length = 119
 copyright-check = True
 select = E,F,W,C
 copyright-regexp=Copyright \(c\) Facebook, Inc. and its affiliates. All Rights Reserved
-ignore=W503,E203,E701,E704
+ignore=W503,E203,E231,E701,E704
diff --git a/.github/workflows/core_tests.yml b/.github/workflows/core_tests.yml
@@ -10,7 +10,6 @@ jobs:
     strategy:
       matrix:
         py_version:
-          - '3.8'
           - '3.9'
           - '3.10'
           - '3.11'
@@ -32,7 +31,6 @@ jobs:
     strategy:
       matrix:
         py_version:
-          - '3.8'
           - '3.9'
           - '3.10'
           - '3.11'
@@ -53,7 +51,6 @@ jobs:
     strategy:
       matrix:
         py_version:
-          - '3.8'
           - '3.9'
           - '3.10'
           - '3.11'
@@ -73,7 +70,6 @@ jobs:
     strategy:
       matrix:
         py_version:
-          - '3.8'
           - '3.9'
           - '3.10'
           - '3.11'
diff --git a/contrib/hydra_torchrun_launcher/setup.py b/contrib/hydra_torchrun_launcher/setup.py
@@ -25,10 +25,11 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT Apache License, Version 2.0",
-        "Programming Language :: Python :: 3.7",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
+        "Programming Language :: Python :: 3.10",
+        "Programming Language :: Python :: 3.11",
     ],
+    python_requires=">=3.9",
     install_requires=["torch>=1.11.0", "hydra-core>=1.1.1"],
     include_package_data=True,
 )
diff --git a/examples/plugins/example_configsource_plugin/setup.py b/examples/plugins/example_configsource_plugin/setup.py
@@ -19,12 +19,12 @@
             "License :: OSI Approved :: MIT License",
             # Hydra uses Python version and Operating system to determine
             # In which environments to test this plugin
-            "Programming Language :: Python :: 3.8",
             "Programming Language :: Python :: 3.9",
             "Programming Language :: Python :: 3.10",
             "Programming Language :: Python :: 3.11",
             "Operating System :: OS Independent",
         ],
+        python_requires=">=3.9",
         install_requires=[
             # consider pinning to a specific major version of Hydra to avoid unexpected problems
             # if a new major version of Hydra introduces breaking changes for plugins.
diff --git a/examples/plugins/example_generic_plugin/setup.py b/examples/plugins/example_generic_plugin/setup.py
@@ -19,12 +19,12 @@
             "License :: OSI Approved :: MIT License",
             # Hydra uses Python version and Operating system to determine
             # In which environments to test this plugin
-            "Programming Language :: Python :: 3.8",
             "Programming Language :: Python :: 3.9",
             "Programming Language :: Python :: 3.10",
             "Programming Language :: Python :: 3.11",
             "Operating System :: OS Independent",
         ],
+        python_requires=">=3.9",
         install_requires=[
             # consider pinning to a specific major version of Hydra to avoid unexpected problems
             # if a new major version of Hydra introduces breaking changes for plugins.
diff --git a/examples/plugins/example_launcher_plugin/setup.py b/examples/plugins/example_launcher_plugin/setup.py
@@ -19,12 +19,12 @@
             "License :: OSI Approved :: MIT License",
             # Hydra uses Python version and Operating system to determine
             # In which environments to test this plugin
-            "Programming Language :: Python :: 3.8",
             "Programming Language :: Python :: 3.9",
             "Programming Language :: Python :: 3.10",
             "Programming Language :: Python :: 3.11",
             "Operating System :: OS Independent",
         ],
+        python_requires=">=3.9",
         install_requires=[
             # consider pinning to a specific major version of Hydra to avoid unexpected problems
             # if a new major version of Hydra introduces breaking changes for plugins.
diff --git a/examples/plugins/example_registered_plugin/setup.py b/examples/plugins/example_registered_plugin/setup.py
@@ -19,12 +19,12 @@
         "License :: OSI Approved :: MIT License",
         # Hydra uses Python version and Operating system to determine
         # In which environments to test this plugin
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Operating System :: OS Independent",
     ],
+    python_requires=">=3.9",
     install_requires=[
         # consider pinning to a specific major version of Hydra to avoid unexpected problems
         # if a new major version of Hydra introduces breaking changes for plugins.
diff --git a/examples/plugins/example_searchpath_plugin/setup.py b/examples/plugins/example_searchpath_plugin/setup.py
@@ -21,12 +21,12 @@
             "License :: OSI Approved :: MIT License",
             # Hydra uses Python version and Operating system to determine
             # In which environments to test this plugin
-            "Programming Language :: Python :: 3.8",
             "Programming Language :: Python :: 3.9",
             "Programming Language :: Python :: 3.10",
             "Programming Language :: Python :: 3.11",
             "Operating System :: OS Independent",
         ],
+        python_requires=">=3.9",
         install_requires=[
             # consider pinning to a specific major version of Hydra to avoid unexpected problems
             # if a new major version of Hydra introduces breaking changes for plugins.
diff --git a/examples/plugins/example_sweeper_plugin/setup.py b/examples/plugins/example_sweeper_plugin/setup.py
@@ -19,12 +19,12 @@
             "License :: OSI Approved :: MIT License",
             # Hydra uses Python version and Operating system to determine
             # In which environments to test this plugin
-            "Programming Language :: Python :: 3.8",
             "Programming Language :: Python :: 3.9",
             "Programming Language :: Python :: 3.10",
             "Programming Language :: Python :: 3.11",
             "Operating System :: OS Independent",
         ],
+        python_requires=">=3.9",
         install_requires=[
             # consider pinning to a specific major version of Hydra to avoid unexpected problems
             # if a new major version of Hydra introduces breaking changes for plugins.
diff --git a/hydra/_internal/core_plugins/importlib_resources_config_source.py b/hydra/_internal/core_plugins/importlib_resources_config_source.py
@@ -1,21 +1,16 @@
 # Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved
 import os
-import sys
 import zipfile
-from typing import TYPE_CHECKING, Any, List, Optional
+from importlib import resources
+from typing import Any, List, Optional
 
 from omegaconf import OmegaConf
 
 from hydra.core.object_type import ObjectType
 from hydra.plugins.config_source import ConfigLoadError, ConfigResult, ConfigSource
 
-if TYPE_CHECKING or (sys.version_info < (3, 9)):
-    import importlib_resources as resources
-else:
-    from importlib import resources
-
-    # Relevant issue: https://github.com/python/mypy/issues/1153
-    # Use importlib backport for Python older than 3.9
+# Relevant issue: https://github.com/python/mypy/issues/1153
+# Python 3.9+ has importlib.resources in the standard library
 
 
 class ImportlibResourcesConfigSource(ConfigSource):
diff --git a/noxfile.py b/noxfile.py
@@ -308,7 +308,7 @@ def _isort_cmd() -> List[str]:
     return isort
 
 
-def _mypy_cmd(strict: bool, python_version: Optional[str] = "3.8") -> List[str]:
+def _mypy_cmd(strict: bool, python_version: Optional[str] = "3.9") -> List[str]:
     mypy = [
         "mypy",
         "--install-types",
@@ -577,7 +577,7 @@ def test_selected_plugins(session: Session, selected_plugins: List[Plugin]) -> N
         run_pytest(session)
 
 
-@nox.session(python="3.8")  # type: ignore
+@nox.session(python="3.9")  # type: ignore
 def coverage(session: Session) -> None:
     _upgrade_basic(session)
     coverage_env = {
diff --git a/plugins/hydra_ax_sweeper/setup.py b/plugins/hydra_ax_sweeper/setup.py
@@ -17,13 +17,13 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Operating System :: POSIX :: Linux",
         "Operating System :: MacOS",
         "Development Status :: 4 - Beta",
     ],
+    python_requires=">=3.9",
     install_requires=[
         "hydra-core>=1.1.0.dev7",
         "ax-platform>=0.1.20,<0.2.1",  # https://github.com/facebookresearch/hydra/issues/1767
diff --git a/plugins/hydra_colorlog/setup.py b/plugins/hydra_colorlog/setup.py
@@ -17,12 +17,12 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Operating System :: OS Independent",
     ],
+    python_requires=">=3.9",
     install_requires=["colorlog", "hydra-core>=1.0.0"],
     include_package_data=True,
 )
diff --git a/plugins/hydra_joblib_launcher/setup.py b/plugins/hydra_joblib_launcher/setup.py
@@ -17,14 +17,14 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Operating System :: MacOS",
         "Operating System :: Microsoft :: Windows",
         "Operating System :: POSIX :: Linux",
     ],
+    python_requires=">=3.9",
     install_requires=[
         "hydra-core>=1.1.0.dev7",
         "joblib>=0.14.0",
diff --git a/plugins/hydra_nevergrad_sweeper/setup.py b/plugins/hydra_nevergrad_sweeper/setup.py
@@ -17,13 +17,13 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Operating System :: OS Independent",
         "Development Status :: 4 - Beta",
     ],
+    python_requires=">=3.9",
     install_requires=[
         "hydra-core>=1.1.0.dev7",
         "nevergrad>=0.4.3.post9",
diff --git a/plugins/hydra_optuna_sweeper/setup.py b/plugins/hydra_optuna_sweeper/setup.py
@@ -17,14 +17,14 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Operating System :: POSIX :: Linux",
         "Operating System :: MacOS",
         "Development Status :: 4 - Beta",
     ],
+    python_requires=">=3.9",
     install_requires=[
         "hydra-core>=1.1.0.dev7",
         "optuna>=2.10.0,<3.0.0",
diff --git a/plugins/hydra_ray_launcher/setup.py b/plugins/hydra_ray_launcher/setup.py
@@ -17,20 +17,19 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Operating System :: MacOS",
         "Operating System :: POSIX :: Linux",
     ],
+    python_requires=">=3.9",
     install_requires=[
         "boto3",
         "hydra-core>=1.1.2",
         "ray[default]<3",
         "aiohttp<4",
         "cloudpickle<3",
-        "pickle5==0.0.12; python_version < '3.8'",
     ],
     include_package_data=True,
 )
diff --git a/plugins/hydra_rq_launcher/setup.py b/plugins/hydra_rq_launcher/setup.py
@@ -17,13 +17,13 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Operating System :: MacOS",
         "Operating System :: POSIX :: Linux",
     ],
+    python_requires=">=3.9",
     install_requires=[
         "cloudpickle",
         "fakeredis<1.7.4",  # https://github.com/dsoftwareinc/fakeredis-py/issues/3
diff --git a/plugins/hydra_submitit_launcher/setup.py b/plugins/hydra_submitit_launcher/setup.py
@@ -17,14 +17,14 @@
     packages=find_namespace_packages(include=["hydra_plugins.*"]),
     classifiers=[
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Operating System :: MacOS",
         "Operating System :: POSIX :: Linux",
         "Development Status :: 4 - Beta",
     ],
+    python_requires=">=3.9",
     install_requires=[
         "hydra-core>=1.1.0.dev7",
         "submitit>=1.3.3",
diff --git a/pyproject.toml b/pyproject.toml
@@ -45,7 +45,7 @@
 
 [tool.black]
 line-length = 88
-target-version = ['py38']
+target-version = ['py39']
 include = '\.pyi?$'
 exclude = '''
 (
diff --git a/setup.py b/setup.py
@@ -46,14 +46,14 @@
         classifiers=[
             "License :: OSI Approved :: MIT License",
             "Development Status :: 4 - Beta",
-            "Programming Language :: Python :: 3.8",
             "Programming Language :: Python :: 3.9",
             "Programming Language :: Python :: 3.10",
             "Programming Language :: Python :: 3.11",
             "Operating System :: POSIX :: Linux",
             "Operating System :: MacOS",
             "Operating System :: Microsoft :: Windows",
         ],
+        python_requires=">=3.9",
         install_requires=install_requires,
         entry_points={"pytest11": ["hydra_pytest = hydra.extra.pytest_plugin"]},
         # Install development dependencies with
diff --git a/website/docs/configure_hydra/Intro.md b/website/docs/configure_hydra/Intro.md
@@ -148,10 +148,10 @@ e.g. for formatting the time you can use something like`${now:%H-%M-%S}`.
 Takes an optional argument of a string with the values major, minor or macro.
 e.g:
 ```yaml
-default: ${python_version:}          # 3.8
+default: ${python_version:}          # 3.9
 major:   ${python_version:major}     # 3
-minor:   ${python_version:minor}     # 3.8
-micro:   ${python_version:micro}     # 3.8.2
+minor:   ${python_version:minor}     # 3.9
+micro:   ${python_version:micro}     # 3.9.1
 ```
 
 Additionally hydra supports OmegaConf <a class="external" href="https://omegaconf.readthedocs.io/en/latest/custom_resolvers.html#custom-resolvers" target="_blank">custom resolvers</a>
diff --git a/website/docs/development/overview.md b/website/docs/development/overview.md
@@ -9,16 +9,16 @@ It is recommended that you install Hydra in a virtual environment like [conda](h
 ## Environment setup
 Install [Miniconda](https://docs.conda.io/en/latest/miniconda.html) and create an empty Conda environment with:
 ```
-conda create -n hydra38 python=3.8 -qy
+conda create -n hydra39 python=3.9 -qy
 ```
 
 :::info NOTE
-The core Hydra framework supports Python 3.8 or newer. You may need to create additional environments for different Python versions if CI detect issues on a supported version of Python.
+The core Hydra framework supports Python 3.9 or newer. You may need to create additional environments for different Python versions if CI detect issues on a supported version of Python.
 :::
 
 Activate the environment:
 ```
-conda activate hydra38
+conda activate hydra39
 ```
 From the source tree, install Hydra in development mode with the following commands:
 ```bash
diff --git a/website/docs/development/testing.md b/website/docs/development/testing.md
@@ -19,20 +19,20 @@ Some plugins support fewer versions of Python than the Hydra core.
 ## Testing with nox
 See `nox -l`. a few examples:
 * `nox -s test_core` will test Hydra core on all supported Python versions
-* `nox -s "test_plugins-3.8"` will test plugins on Python 3.8.
-* `nox -s "test_plugins-3.8"` will test plugins on Python 3.8.
+* `nox -s "test_plugins-3.9"` will test plugins on Python 3.9.
+* `nox -s "test_plugins-3.9"` will test plugins on Python 3.9.
 
 The `noxfile.py` is checking some environment variables to decide what to run. For example,
 to test a single plugin:
 ```shell {4}
-$ PLUGINS=hydra_colorlog nox -s test_plugins-3.8
+$ PLUGINS=hydra_colorlog nox -s test_plugins-3.9
 Operating system        :       Linux
-NOX_PYTHON_VERSIONS     :       ['3.8', '3.9', '3.10', '3.11']
+NOX_PYTHON_VERSIONS     :       ['3.9', '3.10', '3.11']
 PLUGINS                 :       ['hydra_colorlog']
 SKIP_CORE_TESTS         :       False
 FIX                     :       False
 VERBOSE                 :       0
 INSTALL_EDITABLE_MODE   :       0
-nox > Running session test_plugins-3.8
+nox > Running session test_plugins-3.9
 ...
 ```
diff --git a/website/docs/tutorials/structured_config/0_intro.md b/website/docs/tutorials/structured_config/0_intro.md
