Resolve comments

Author: wsmoses

include/tc/core/mapping_options.h

@@ -192,7 +192,6 @@ class SchedulerOptionsView {
   /// Construct a view that refers to a protocol buffers message.
   SchedulerOptionsView(const SchedulerOptionsView&) = default;
   SchedulerOptionsView(SchedulerOptionsProto& buf) : proto(buf) {}
-  SchedulerOptionsView(SchedulerOptionsProto&& buf) : proto(buf) {}
 
   /// Assign the values from another view.
   inline SchedulerOptionsView& operator=(const SchedulerOptionsView&);

include/tc/core/polyhedral/scop.h

@@ -337,11 +337,6 @@ struct Scop {
     return scheduleTreeUPtr.get();
   }
 
-  // Create a Scop scheduled with a given scheduling strategy.
-  static std::unique_ptr<Scop> makeScheduled(
-      const Scop& scop,
-      const SchedulerOptionsView&& schedulerOptions);
-
   // Create a Scop scheduled with a given scheduling strategy.
   static std::unique_ptr<Scop> makeScheduled(
       const Scop& scop,

src/core/polyhedral/scop.cc

@@ -463,17 +463,6 @@ std::unique_ptr<Scop> Scop::makeScheduled(
   return s;
 }
 
-std::unique_ptr<Scop> Scop::makeScheduled(
-    const Scop& scop,
-    const SchedulerOptionsView&& schedulerOptions) {
-  auto s = makeScop(scop);
-  auto constraints = makeScheduleConstraints(*s, schedulerOptions);
-  s->scheduleTreeUPtr = computeSchedule(constraints, schedulerOptions);
-  LOG_IF(INFO, FLAGS_debug_tc_mapper) << "After scheduling:" << std::endl
-                                      << *s->scheduleTreeUPtr;
-  return s;
-}
-
 namespace {
 
 /*

test/test_mapper_llvm.cc

@@ -68,7 +68,7 @@ def fun(float(N, M) A, float(N, M) B) -> (C) {
 TEST(LLVMCodegen, BasicParallel) {
   string tc = R"TC(
 def fun(float(N, M) A, float(N, M) B) -> (C) {
-  C(i, j) = A(i, j) + B(i, j)
+  C(n, m) = A(n, m) + B(n, m)
 }
 )TC";
   auto N = 40;
@@ -79,8 +79,9 @@ def fun(float(N, M) A, float(N, M) B) -> (C) {
   auto context = scop->makeContext(
       std::unordered_map<std::string, int>{{"N", N}, {"M", M}});
   scop = Scop::makeSpecializedScop(*scop, context);
-  scop =
-      Scop::makeScheduled(*scop, SchedulerOptionsView(SchedulerOptionsProto()));
+  SchedulerOptionsProto sop;
+  SchedulerOptionsView sov(sop);
+  scop = Scop::makeScheduled(*scop, sov);
   Jit jit;
   auto mod = jit.codegenScop("kernel_anon", *scop);
   auto correct_llvm = R"LLVM(