Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Commit de59ea2

Browse files
authored
Merge pull request #19 from facebookresearch/update-temporaries-docs
Update docs and write about temporaties explicitly
2 parents cea9a88 + b46ab26 commit de59ea2

File tree

3 files changed

+22
-5
lines changed

3 files changed

+22
-5
lines changed

docs/source/docker_image.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ The conda and non-conda images for each setup are below:
3535
TC runtime image with nvidia-docker
3636
-----------------------------------
3737

38-
We also provide a runtime nvidia-docker image for `Ubuntu 14.04`, gcc 4.8, CUDA 8 and CUDNN 6. Using this image,
39-
you can also run gpu tests. To run the image, make sure you have `nvidia-docker` installed. Then run the image using
40-
following command:
38+
We also provide a runtime nvidia-docker image for :code:`Ubuntu 14.04`, :code:`gcc 4.8`, :code:`CUDA 8` and :code:`CUDNN 6`.
39+
Using this image, you can also run gpu tests. To run the image, make sure you
40+
have :code:`nvidia-docker` installed. Then run the image using following command:
4141

4242
* :code:`NVIDIA-Docker Ubuntu 14.04 conda environment`
4343

docs/source/installation.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
Installation Guide
22
==================
33

4+
**Author**: `Priya Goyal <https://github.com/prigoyal>`_
5+
46
The following instructions are provided for developers who would like to
57
experiment with the library.
68

@@ -16,4 +18,4 @@ Some users might prefer building TC in :code:`non-conda` enviroment and some mig
1618

1719
Further, we also provide runtime :code:`docker` images for both :code:`conda` and :code:`non-conda` environment and also an :code:`nvidia-docker` runtime image for TC to have access to GPUs.
1820

19-
You can chose whatever build settings suit your requirements best and follow the instructions to build.
21+
You can chose whatever build settings suit your requirements best and follow the instructions to build. Please feel free to contact us in case you need help with build.

docs/source/ml_with_tc.rst

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,21 @@ scope in a TC, allocations etc (i.e. all the basic stuff you expect from a
3838
Programming Language). As a consequence TC is not a Programming Language but a concise
3939
notation. For now, it should not try to be a Programming Language.
4040

41+
As a result of this, everything in TC should be either an input or output. For example:
42+
consider the TC definition below:
43+
44+
.. code::
45+
46+
def softmax(float(N, D) I) -> (O, expsum) {
47+
expsum(n) +=! exp(I(n, d))
48+
O(n, d) = exp(I(n, d)) / expsum(n)
49+
}
50+
51+
In this TC, :code:`expsum` is a temporary variable that needs to be computed but
52+
since TC doesn't do allocations itself, we set it as another output. User can chose
53+
to ignore this output. We will work on enhancing this and deal with temporary
54+
allocations better in future.
55+
4156
Graph Level
4257
^^^^^^^^^^^
4358

@@ -79,7 +94,7 @@ TC
7994
^^
8095

8196
The current TC implementation sits somewhere here; less verbose than Halide,
82-
more verbose than matrix algebra. The inference procedure has been one subtle
97+
more verbose than matrix algebra. The inference procedure has been one subtle
8398
tradeoff in TC. It has been designed to follow an intuitive enough mental model,
8499
but may still evolve in the future towards greater expressiveness, see :ref:`inference`.
85100

0 commit comments

Comments
 (0)