Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Commit c4082d6

Browse files
author
Sven Verdoolaege
committed
rename approximateFootprint to approximateScopedAccesses
Commit a106e7e (TensorReferenceGroup::approximateFootprint: return relative footprint, Wed Jun 13 15:49:43 2018 +0200) changed approximateFootprint to return a relative footprint without modifying its name. Use a name that is more similar to other TensorReferenceGroup methods that return a relative footprint.
1 parent d3f8386 commit c4082d6

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

tc/core/polyhedral/memory_promotion.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ std::unique_ptr<TensorReferenceGroup> TensorReferenceGroup::makeSingleton(
115115
return group;
116116
}
117117

118-
isl::map TensorReferenceGroup::approximateFootprint() const {
118+
isl::map TensorReferenceGroup::approximateScopedAccesses() const {
119119
auto scopedDomain = scopedAccesses().domain();
120120
auto space = approximation.box.get_space();
121121
auto accessed = isl::map::universe(space).intersect_domain(scopedDomain);
@@ -271,8 +271,8 @@ void joinOverlappingWrites(
271271
if (g1->isReadOnly() && g2->isReadOnly()) {
272272
continue;
273273
}
274-
if (g1->approximateFootprint()
275-
.intersect(g2->approximateFootprint())
274+
if (g1->approximateScopedAccesses()
275+
.intersect(g2->approximateScopedAccesses())
276276
.is_empty()) {
277277
continue;
278278
}
@@ -518,7 +518,7 @@ ScheduleTree* insertCopiesUnder(
518518
auto arrayId =
519519
promotionSpace.domain().unwrap().get_tuple_id(isl::dim_type::out);
520520
auto approximatedRead =
521-
group.approximateFootprint().intersect_range(tensorElements).wrap();
521+
group.approximateScopedAccesses().intersect_range(tensorElements).wrap();
522522
approximatedRead = approximatedRead.product(promotedFootprint);
523523
auto readExtension = extension.intersect_range(approximatedRead)
524524
.set_tuple_id(isl::dim_type::out, readId);

tc/core/polyhedral/memory_promotion.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ class TensorReferenceGroup {
143143

144144
// Rectangular overapproximation of the set of tensor elements accessed below
145145
// and relative to the scoping point.
146-
isl::map approximateFootprint() const;
146+
isl::map approximateScopedAccesses() const;
147147

148148
isl::multi_aff promotion() const;
149149
isl::set promotedFootprint() const;

test/test_cuda_mapper_memory_promotion.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ def fun(float(N, M) A, float(N, M) B) -> (C) {
305305
EXPECT_EQ(
306306
oneGroup->approximation.size(1),
307307
isl::val(ctx, std::min(tile2, problemSize2)));
308-
auto footprint = tileZero.apply(oneGroup->approximateFootprint());
308+
auto footprint = tileZero.apply(oneGroup->approximateScopedAccesses());
309309
size_t np = npoints(footprint);
310310
EXPECT_EQ(
311311
np, std::min(tile1, problemSize1) * std::min(tile2, problemSize2));

0 commit comments

Comments
 (0)