Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Commit b716d7f

Browse files
author
Sven Verdoolaege
committed
properly override isl CMakeLists.txt ISL_INT setting
Prior to b72b7f1 (Redo the build system, Tue May 22 09:32:11 2018 -0600), the ISL_INT GMP value would be set on the command line, which apparently overrides the cache setting, in isl's CMakeLists.txt. However, since that commit, the _first_ time isl's CMakeLists.txt is run, it would initialize ISL_INT to imath (ignoring the value set in TC's CMakeLists.txt), while on any further run, the value set in TC's CMakeLists.txt would override the cache value and isl's CMakeLists.txt would keep the gmp value. Now, it is not clear why a fork of isl that is specific to TC would set the value to imath in the first place if TC wants this value to be gmp, but given this situation, let TC's CMakeLists.txt create the cache entry such that it gets initialized to the proper value and in particular doesn't change over different runs.
1 parent 3ed7f4a commit b716d7f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ message(STATUS "Found ATen.so file: ${ATEN_LIBRARIES}")
226226
################################################################################
227227
# isl
228228
################################################################################
229-
set(ISL_INT gmp)
229+
set(ISL_INT "gmp" CACHE STRING "Which package to use to represent multi-precision integers (gmp|imath)")
230230
include_directories(AFTER ${PROJECT_SOURCE_DIR}/third-party/islpp/include)
231231
include_directories(AFTER ${CMAKE_CURRENT_BINARY_DIR}/third-party/islpp/include)
232232
add_subdirectory(third-party/islpp)

0 commit comments

Comments
 (0)