Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Commit 87a64bb

Browse files
Merge pull request #585 from facebookresearch/pr/fix_aff_val_export
bump isl for fix of isl_*_aff_*_val exports
2 parents e3dac83 + 46c9cd7 commit 87a64bb

File tree

3 files changed

+59
-33
lines changed

3 files changed

+59
-33
lines changed

isl_interface/include/isl/cpp.h

Lines changed: 56 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1948,11 +1948,11 @@ class multi_union_pw_aff {
19481948
public:
19491949
inline /* implicit */ multi_union_pw_aff();
19501950
inline /* implicit */ multi_union_pw_aff(const isl::multi_union_pw_aff &obj);
1951-
inline explicit multi_union_pw_aff(isl::union_set domain, isl::multi_aff ma);
19521951
inline explicit multi_union_pw_aff(isl::space space, isl::union_pw_aff_list list);
19531952
inline /* implicit */ multi_union_pw_aff(isl::union_pw_aff upa);
19541953
inline /* implicit */ multi_union_pw_aff(isl::multi_pw_aff mpa);
19551954
inline explicit multi_union_pw_aff(isl::union_set domain, isl::multi_val mv);
1955+
inline explicit multi_union_pw_aff(isl::union_set domain, isl::multi_aff ma);
19561956
inline explicit multi_union_pw_aff(isl::ctx ctx, const std::string &str);
19571957
inline isl::multi_union_pw_aff &operator=(isl::multi_union_pw_aff obj);
19581958
inline ~multi_union_pw_aff();
@@ -2164,6 +2164,7 @@ class pw_aff {
21642164
inline int n_piece() const;
21652165
inline isl::set ne_set(isl::pw_aff pwaff2) const;
21662166
inline isl::pw_aff neg() const;
2167+
inline isl::set nonneg_set() const;
21672168
inline isl::set params() const;
21682169
inline isl::pw_aff project_domain_on_params() const;
21692170
inline isl::pw_aff pullback(isl::multi_aff ma) const;
@@ -2175,6 +2176,7 @@ class pw_aff {
21752176
inline isl::pw_aff tdiv_q(isl::pw_aff pa2) const;
21762177
inline isl::pw_aff tdiv_r(isl::pw_aff pa2) const;
21772178
inline isl::pw_aff union_add(isl::pw_aff pwaff2) const;
2179+
inline isl::set zero_set() const;
21782180
typedef isl_pw_aff* isl_ptr_t;
21792181
};
21802182

@@ -2266,8 +2268,8 @@ class pw_multi_aff {
22662268
inline isl::pw_multi_aff range_factor_domain() const;
22672269
inline isl::pw_multi_aff range_factor_range() const;
22682270
inline isl::pw_multi_aff range_product(isl::pw_multi_aff pma2) const;
2269-
inline isl::pw_multi_aff scale_down_val(isl::val v) const;
2270-
inline isl::pw_multi_aff scale_val(isl::val v) const;
2271+
inline isl::pw_multi_aff scale(isl::val v) const;
2272+
inline isl::pw_multi_aff scale_down(isl::val v) const;
22712273
inline isl::pw_multi_aff set_pw_aff(unsigned int pos, isl::pw_aff pa) const;
22722274
inline isl::pw_multi_aff union_add(isl::pw_multi_aff pma2) const;
22732275
typedef isl_pw_multi_aff* isl_ptr_t;
@@ -3144,8 +3146,8 @@ class union_pw_aff {
31443146
static inline isl::union_pw_aff param_on_domain(isl::union_set domain, isl::id id);
31453147
inline bool plain_is_equal(const isl::union_pw_aff &upa2) const;
31463148
inline isl::union_pw_aff pullback(isl::union_pw_multi_aff upma) const;
3149+
inline isl::union_pw_aff scale(isl::val v) const;
31473150
inline isl::union_pw_aff scale_down(isl::val v) const;
3148-
inline isl::union_pw_aff scale_val(isl::val v) const;
31493151
inline isl::union_pw_aff sub(isl::union_pw_aff upa2) const;
31503152
inline isl::union_pw_aff union_add(isl::union_pw_aff upa2) const;
31513153
inline isl::union_set zero_union_set() const;
@@ -3232,8 +3234,8 @@ class union_pw_multi_aff {
32323234
inline isl::union_pw_aff get_union_pw_aff(int pos) const;
32333235
inline int n_pw_multi_aff() const;
32343236
inline isl::union_pw_multi_aff pullback(isl::union_pw_multi_aff upma2) const;
3235-
inline isl::union_pw_multi_aff scale_down_val(isl::val val) const;
3236-
inline isl::union_pw_multi_aff scale_val(isl::val val) const;
3237+
inline isl::union_pw_multi_aff scale(isl::val val) const;
3238+
inline isl::union_pw_multi_aff scale_down(isl::val val) const;
32373239
inline isl::union_pw_multi_aff union_add(isl::union_pw_multi_aff upma2) const;
32383240
typedef isl_union_pw_multi_aff* isl_ptr_t;
32393241
};
@@ -11362,18 +11364,6 @@ multi_union_pw_aff::multi_union_pw_aff(const isl::multi_union_pw_aff &obj)
1136211364
multi_union_pw_aff::multi_union_pw_aff(__isl_take isl_multi_union_pw_aff *ptr)
1136311365
: ptr(ptr) {}
1136411366

11365-
multi_union_pw_aff::multi_union_pw_aff(isl::union_set domain, isl::multi_aff ma)
11366-
{
11367-
if (domain.is_null() || ma.is_null())
11368-
throw isl::exception::create(isl_error_invalid,
11369-
"NULL input", __FILE__, __LINE__);
11370-
auto ctx = domain.get_ctx();
11371-
options_scoped_set_on_error saved_on_error(ctx, ISL_ON_ERROR_CONTINUE);
11372-
auto res = isl_multi_union_pw_aff_multi_aff_on_domain(domain.release(), ma.release());
11373-
if (!res)
11374-
throw exception::create_from_last_error(ctx);
11375-
ptr = res;
11376-
}
1137711367
multi_union_pw_aff::multi_union_pw_aff(isl::space space, isl::union_pw_aff_list list)
1137811368
{
1137911369
if (space.is_null() || list.is_null())
@@ -11422,6 +11412,18 @@ multi_union_pw_aff::multi_union_pw_aff(isl::union_set domain, isl::multi_val mv)
1142211412
throw exception::create_from_last_error(ctx);
1142311413
ptr = res;
1142411414
}
11415+
multi_union_pw_aff::multi_union_pw_aff(isl::union_set domain, isl::multi_aff ma)
11416+
{
11417+
if (domain.is_null() || ma.is_null())
11418+
throw isl::exception::create(isl_error_invalid,
11419+
"NULL input", __FILE__, __LINE__);
11420+
auto ctx = domain.get_ctx();
11421+
options_scoped_set_on_error saved_on_error(ctx, ISL_ON_ERROR_CONTINUE);
11422+
auto res = isl_multi_union_pw_aff_multi_aff_on_domain(domain.release(), ma.release());
11423+
if (!res)
11424+
throw exception::create_from_last_error(ctx);
11425+
ptr = res;
11426+
}
1142511427
multi_union_pw_aff::multi_union_pw_aff(isl::ctx ctx, const std::string &str)
1142611428
{
1142711429
options_scoped_set_on_error saved_on_error(ctx, ISL_ON_ERROR_CONTINUE);
@@ -13056,6 +13058,18 @@ isl::pw_aff pw_aff::neg() const
1305613058
return manage(res);
1305713059
}
1305813060

13061+
isl::set pw_aff::nonneg_set() const
13062+
{
13063+
if (!ptr)
13064+
throw isl::exception::create(isl_error_invalid,
13065+
"NULL input", __FILE__, __LINE__);
13066+
options_scoped_set_on_error saved_on_error(get_ctx(), ISL_ON_ERROR_CONTINUE);
13067+
auto res = isl_pw_aff_nonneg_set(copy());
13068+
if (!res)
13069+
throw exception::create_from_last_error(get_ctx());
13070+
return manage(res);
13071+
}
13072+
1305913073
isl::set pw_aff::params() const
1306013074
{
1306113075
if (!ptr)
@@ -13188,6 +13202,18 @@ isl::pw_aff pw_aff::union_add(isl::pw_aff pwaff2) const
1318813202
return manage(res);
1318913203
}
1319013204

13205+
isl::set pw_aff::zero_set() const
13206+
{
13207+
if (!ptr)
13208+
throw isl::exception::create(isl_error_invalid,
13209+
"NULL input", __FILE__, __LINE__);
13210+
options_scoped_set_on_error saved_on_error(get_ctx(), ISL_ON_ERROR_CONTINUE);
13211+
auto res = isl_pw_aff_zero_set(copy());
13212+
if (!res)
13213+
throw exception::create_from_last_error(get_ctx());
13214+
return manage(res);
13215+
}
13216+
1319113217
// implementations for isl::pw_aff_list
1319213218
isl::pw_aff_list manage(__isl_take isl_pw_aff_list *ptr) {
1319313219
if (!ptr)
@@ -13752,25 +13778,25 @@ isl::pw_multi_aff pw_multi_aff::range_product(isl::pw_multi_aff pma2) const
1375213778
return manage(res);
1375313779
}
1375413780

13755-
isl::pw_multi_aff pw_multi_aff::scale_down_val(isl::val v) const
13781+
isl::pw_multi_aff pw_multi_aff::scale(isl::val v) const
1375613782
{
1375713783
if (!ptr || v.is_null())
1375813784
throw isl::exception::create(isl_error_invalid,
1375913785
"NULL input", __FILE__, __LINE__);
1376013786
options_scoped_set_on_error saved_on_error(get_ctx(), ISL_ON_ERROR_CONTINUE);
13761-
auto res = isl_pw_multi_aff_scale_down_val(copy(), v.release());
13787+
auto res = isl_pw_multi_aff_scale_val(copy(), v.release());
1376213788
if (!res)
1376313789
throw exception::create_from_last_error(get_ctx());
1376413790
return manage(res);
1376513791
}
1376613792

13767-
isl::pw_multi_aff pw_multi_aff::scale_val(isl::val v) const
13793+
isl::pw_multi_aff pw_multi_aff::scale_down(isl::val v) const
1376813794
{
1376913795
if (!ptr || v.is_null())
1377013796
throw isl::exception::create(isl_error_invalid,
1377113797
"NULL input", __FILE__, __LINE__);
1377213798
options_scoped_set_on_error saved_on_error(get_ctx(), ISL_ON_ERROR_CONTINUE);
13773-
auto res = isl_pw_multi_aff_scale_val(copy(), v.release());
13799+
auto res = isl_pw_multi_aff_scale_down_val(copy(), v.release());
1377413800
if (!res)
1377513801
throw exception::create_from_last_error(get_ctx());
1377613802
return manage(res);
@@ -19180,25 +19206,25 @@ isl::union_pw_aff union_pw_aff::pullback(isl::union_pw_multi_aff upma) const
1918019206
return manage(res);
1918119207
}
1918219208

19183-
isl::union_pw_aff union_pw_aff::scale_down(isl::val v) const
19209+
isl::union_pw_aff union_pw_aff::scale(isl::val v) const
1918419210
{
1918519211
if (!ptr || v.is_null())
1918619212
throw isl::exception::create(isl_error_invalid,
1918719213
"NULL input", __FILE__, __LINE__);
1918819214
options_scoped_set_on_error saved_on_error(get_ctx(), ISL_ON_ERROR_CONTINUE);
19189-
auto res = isl_union_pw_aff_scale_down_val(copy(), v.release());
19215+
auto res = isl_union_pw_aff_scale_val(copy(), v.release());
1919019216
if (!res)
1919119217
throw exception::create_from_last_error(get_ctx());
1919219218
return manage(res);
1919319219
}
1919419220

19195-
isl::union_pw_aff union_pw_aff::scale_val(isl::val v) const
19221+
isl::union_pw_aff union_pw_aff::scale_down(isl::val v) const
1919619222
{
1919719223
if (!ptr || v.is_null())
1919819224
throw isl::exception::create(isl_error_invalid,
1919919225
"NULL input", __FILE__, __LINE__);
1920019226
options_scoped_set_on_error saved_on_error(get_ctx(), ISL_ON_ERROR_CONTINUE);
19201-
auto res = isl_union_pw_aff_scale_val(copy(), v.release());
19227+
auto res = isl_union_pw_aff_scale_down_val(copy(), v.release());
1920219228
if (!res)
1920319229
throw exception::create_from_last_error(get_ctx());
1920419230
return manage(res);
@@ -19704,25 +19730,25 @@ isl::union_pw_multi_aff union_pw_multi_aff::pullback(isl::union_pw_multi_aff upm
1970419730
return manage(res);
1970519731
}
1970619732

19707-
isl::union_pw_multi_aff union_pw_multi_aff::scale_down_val(isl::val val) const
19733+
isl::union_pw_multi_aff union_pw_multi_aff::scale(isl::val val) const
1970819734
{
1970919735
if (!ptr || val.is_null())
1971019736
throw isl::exception::create(isl_error_invalid,
1971119737
"NULL input", __FILE__, __LINE__);
1971219738
options_scoped_set_on_error saved_on_error(get_ctx(), ISL_ON_ERROR_CONTINUE);
19713-
auto res = isl_union_pw_multi_aff_scale_down_val(copy(), val.release());
19739+
auto res = isl_union_pw_multi_aff_scale_val(copy(), val.release());
1971419740
if (!res)
1971519741
throw exception::create_from_last_error(get_ctx());
1971619742
return manage(res);
1971719743
}
1971819744

19719-
isl::union_pw_multi_aff union_pw_multi_aff::scale_val(isl::val val) const
19745+
isl::union_pw_multi_aff union_pw_multi_aff::scale_down(isl::val val) const
1972019746
{
1972119747
if (!ptr || val.is_null())
1972219748
throw isl::exception::create(isl_error_invalid,
1972319749
"NULL input", __FILE__, __LINE__);
1972419750
options_scoped_set_on_error saved_on_error(get_ctx(), ISL_ON_ERROR_CONTINUE);
19725-
auto res = isl_union_pw_multi_aff_scale_val(copy(), val.release());
19751+
auto res = isl_union_pw_multi_aff_scale_down_val(copy(), val.release());
1972619752
if (!res)
1972719753
throw exception::create_from_last_error(get_ctx());
1972819754
return manage(res);

tc/core/polyhedral/schedule_transforms.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,10 +229,10 @@ ScheduleTree* bandTile(
229229
if (ts[i]) {
230230
upa = upa.scale_down(isl::val(st->ctx_, ts[i])).floor();
231231
if (tileOptions & TileOptions::ScaleTileLoops) {
232-
upa = upa.scale_val(isl::val(st->ctx_, ts[i]));
232+
upa = upa.scale(isl::val(st->ctx_, ts[i]));
233233
}
234234
} else {
235-
upa = upa.scale_val(isl::val(st->ctx_, ts[i]));
235+
upa = upa.scale(isl::val(st->ctx_, ts[i]));
236236
}
237237
band.mupa_ = band.mupa_.set_union_pw_aff(i, upa);
238238
}

third-party/islpp

Submodule islpp updated from adefea1 to 3da9dd0

0 commit comments

Comments
 (0)