Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Commit 346ccf1

Browse files
author
Sven Verdoolaege
committed
drop unused "mu wrappers"
Since these wrappers are unused, they should be removed as dead code. They are apparently also dangerous (judging from the WARNING), so the removal will make sure they don't get used in the future. In particular, if these abstractions give the impression that they could be used to modify parts of isl expressions in place, then they should be killed with fire. isl objects should be modified through high-level isl functions and not by trying to tinker with the representation. The MUPA wrapper (along with its dependencies) is still in use at this point and is left in by this commit. It will be removed later. In particular, one use reveals a missing high-level isl function, which should be added and used instead, one use disappears after some simplification of the code and the remaining use can be replaced by a call to get_union_pw_aff_list(), which will also be added to isl.
1 parent 6712ed3 commit 346ccf1

File tree

1 file changed

+0
-75
lines changed

1 file changed

+0
-75
lines changed

include/tc/external/detail/isl_mu_wrappers.h

Lines changed: 0 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -93,36 +93,6 @@ namespace isl {
9393
// cout << "PA[0] aff: " << M[0][0][0].second << endl;
9494
//
9595

96-
//
97-
// multi_val is a vector of val in the vector space ```multi_val.get_space()```
98-
// A val however is not attached to any (exposed) space (internally it seems
99-
// to have one, see ```isl/isl_val_private.h```).
100-
//
101-
/* WARNING: this does not allow inplace modifications .. ugh */
102-
struct MV : std::vector<isl::val> {
103-
explicit MV(isl::multi_val mv_) : mv(mv_) {
104-
this->reserve(mv.dim(isl::dim_type::set));
105-
for (size_t i = 0; i < mv.dim(isl::dim_type::set); ++i) {
106-
this->push_back(mv.get_val(i));
107-
}
108-
}
109-
isl::multi_val mv;
110-
};
111-
112-
//
113-
// multi_aff is a vector of aff in the vector space ```multi_aff.get_space()```
114-
//
115-
/* WARNING: this does not allow inplace modifications .. ugh */
116-
struct MA : std::vector<isl::aff> {
117-
explicit MA(isl::multi_aff ma_) : ma(ma_) {
118-
this->reserve(ma.dim(isl::dim_type::set));
119-
for (size_t i = 0; i < ma.dim(isl::dim_type::set); ++i) {
120-
this->push_back(ma.get_aff(i));
121-
}
122-
}
123-
isl::multi_aff ma;
124-
};
125-
12696
/* WARNING: this does not allow inplace modifications .. ugh */
12797
struct PA : std::vector<std::pair<isl::set, isl::aff>> {
12898
explicit PA(isl::pw_aff pa_) : pa(pa_) {
@@ -135,18 +105,6 @@ struct PA : std::vector<std::pair<isl::set, isl::aff>> {
135105
isl::pw_aff pa;
136106
};
137107

138-
/* WARNING: this does not allow inplace modifications .. ugh */
139-
struct PMA : std::vector<std::pair<isl::set, isl::multi_aff>> {
140-
explicit PMA(isl::pw_multi_aff pma_) : pma(pma_) {
141-
this->reserve(pma.n_piece());
142-
auto f = [&](isl::set s, isl::multi_aff ma) {
143-
this->push_back(std::make_pair(s, ma));
144-
};
145-
pma.foreach_piece(f);
146-
}
147-
isl::pw_multi_aff pma;
148-
};
149-
150108
/* WARNING: this does not allow inplace modifications .. ugh */
151109
struct UPA : std::vector<PA> {
152110
explicit UPA(isl::union_pw_aff upa_) : upa(upa_) {
@@ -160,36 +118,6 @@ struct UPA : std::vector<PA> {
160118
isl::union_pw_aff upa;
161119
};
162120

163-
struct MPA : std::vector<PA> {
164-
explicit MPA(isl::multi_pw_aff mpa_) : mpa(mpa_) {
165-
this->reserve(mpa.dim(isl::dim_type::set));
166-
for (size_t i = 0; i < mpa.dim(isl::dim_type::set); ++i) {
167-
this->push_back(PA(mpa.get_pw_aff(i)));
168-
}
169-
}
170-
isl::multi_pw_aff mpa;
171-
};
172-
173-
/* WARNING: this does not allow inplace modifications .. ugh */
174-
struct UPMA : std::vector<UPA> {
175-
explicit UPMA(isl::union_pw_multi_aff upma_) : upma(upma_) {
176-
this->reserve(upma.dim(isl::dim_type::set));
177-
for (size_t i = 0; i < upma.dim(isl::dim_type::set); ++i) {
178-
this->push_back(UPA(upma.get_union_pw_aff(i)));
179-
}
180-
}
181-
std::vector<PMA> pmas(isl::union_pw_multi_aff upma) const {
182-
std::vector<PMA> res;
183-
auto f = [&](isl::pw_multi_aff pma) { res.push_back(PMA(pma)); };
184-
upma.foreach_pw_multi_aff(f);
185-
return res;
186-
}
187-
PMA extract(isl::space s) const {
188-
return PMA(upma.extract_pw_multi_aff(s));
189-
}
190-
isl::union_pw_multi_aff upma;
191-
};
192-
193121
/* WARNING: this does not allow inplace modifications .. ugh */
194122
struct MUPA : std::vector<UPA> {
195123
explicit MUPA(isl::multi_union_pw_aff mupa_) : mupa(mupa_) {
@@ -198,9 +126,6 @@ struct MUPA : std::vector<UPA> {
198126
this->push_back(UPA(mupa.get_union_pw_aff(i)));
199127
}
200128
}
201-
MPA extract(isl::space s) const {
202-
return MPA(mupa.extract_multi_pw_aff(s));
203-
}
204129
isl::multi_union_pw_aff mupa;
205130
};
206131

0 commit comments

Comments
 (0)