Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Commit 241a753

Browse files
[RFC] Implicit options from view with underlying copy
This seems non-surprising to me but better RFC. Comments?
1 parent 8fce4cb commit 241a753

File tree

2 files changed

+10
-15
lines changed

2 files changed

+10
-15
lines changed

include/tc/core/mapping_options-inl.h

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -243,34 +243,29 @@ MappingOptions MappingOptions::makeUnmappedMappingOptions() {
243243
}
244244

245245
MappingOptions MappingOptions::makeNaiveMappingOptions() {
246-
return MappingOptions(
247-
makeUnmappedMappingOptions().view.tile({32, 32, 32}).unroll(1));
246+
return makeUnmappedMappingOptions().view.tile({32, 32, 32}).unroll(1);
248247
}
249248

250249
MappingOptions MappingOptions::makeSingleThreadMappingOptions() {
251-
return MappingOptions(makeUnmappedMappingOptions().view.tile({1}).unroll(1));
250+
return makeUnmappedMappingOptions().view.tile({1}).unroll(1);
252251
}
253252

254253
MappingOptions MappingOptions::makePointwiseMappingOptions() {
255-
return MappingOptions(
256-
makeUnmappedMappingOptions().view.tile({32, 32, 32}).unroll(128));
254+
return makeUnmappedMappingOptions().view.tile({32, 32, 32}).unroll(128);
257255
}
258256

259257
MappingOptions MappingOptions::makeMlpMappingOptions() {
260-
return MappingOptions(
261-
makeUnmappedMappingOptions()
262-
.view.outerScheduleFusionStrategy(FusionStrategy::Max)
263-
.tile({1})
264-
.unroll(1));
258+
return makeUnmappedMappingOptions()
259+
.view.outerScheduleFusionStrategy(FusionStrategy::Max)
260+
.tile({1})
261+
.unroll(1);
265262
}
266263

267264
MappingOptions MappingOptions::makeConvolutionMappingOptions() {
268-
return MappingOptions(
269-
makeUnmappedMappingOptions().view.tile({4, 8, 8, 8}).unroll(1));
265+
return makeUnmappedMappingOptions().view.tile({4, 8, 8, 8}).unroll(1);
270266
}
271267

272268
MappingOptions MappingOptions::makeGroupConvolutionMappingOptions() {
273-
return MappingOptions(
274-
makeUnmappedMappingOptions().view.tile({1, 1}).unroll(1));
269+
return makeUnmappedMappingOptions().view.tile({1, 1}).unroll(1);
275270
}
276271
} // namespace tc

include/tc/core/mapping_options.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ class MappingOptions {
315315
explicit MappingOptions(const MappingOptionsProto& proto)
316316
: ownedProto_(proto), view(ownedProto_) {}
317317
/// Performs an underlying copy of the proto viewed by ```view```
318-
explicit MappingOptions(const MappingOptionsView& view)
318+
/* implicit */ MappingOptions(const MappingOptionsView& view)
319319
: ownedProto_(view.proto), view(ownedProto_) {}
320320

321321
std::string toProtobufSerializedString() const {

0 commit comments

Comments
 (0)