Merge pull request #154 from mingzhe09088/fix-destructor

prigoyal · web-flow · commit 21330075c8cf · 2018-03-14T15:14:31.000-04:00
Fix compilation issue: has virtual functions but non-virtual destructor
diff --git a/include/tc/lang/tree.h b/include/tc/lang/tree.h
@@ -89,6 +89,7 @@ struct Tree : std::enable_shared_from_this<Tree> {
     }
   }
   int kind_;
+  virtual ~Tree() {}
 };
 
 struct String : public Tree {

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ struct Tree : std::enable_shared_from_this<Tree> {`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`	`int kind_;`
	`92`	`+ virtual ~Tree() {}`
`92`	`93`	`};`
`93`	`94`
`94`	`95`	`struct String : public Tree {`