Skip to content

Commit f08416b

Browse files
benbrittainfacebook-github-bot
authored andcommitted
Merge platform maps in universe library merges (#79)
Summary: Pull Request resolved: #79 Reviewed By: cjlongoria Differential Revision: D76018225 Pulled By: dtolnay fbshipit-source-id: 535b9a20ba64024119881b938e776ea3617c08e1
1 parent 67d7fda commit f08416b

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/universe.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,15 @@ pub fn merge_universes(
113113
old.env.merge(new.env);
114114
}
115115
fn merge_library(old: &mut RustLibrary, new: RustLibrary) {
116-
// TODO: merge platform maps instead of unwrapping (I think platform
117-
// keys can differ? They certainly will if we add per-universe fixups)
118-
for (platform, select) in new.common.platform {
119-
merge_selects(old.common.platform.get_mut(&platform).unwrap(), select);
116+
for (platform, new_select) in new.common.platform {
117+
match old.common.platform.get_mut(&platform) {
118+
Some(old_select) => {
119+
merge_selects(old_select, new_select);
120+
}
121+
None => {
122+
old.common.platform.insert(platform, new_select);
123+
}
124+
}
120125
}
121126
merge_selects(&mut old.common.base, new.common.base);
122127
}

0 commit comments

Comments
 (0)