Clarification on recommended media query syntax (v0.12.0 deprecation vs v0.13.0 example) #1080
Closed
JuanFuentes20
started this conversation in
General
Replies: 1 comment 1 reply
-
You're right. This was a mistake in the blog post that will be corrected. Thanks for pointing it out You should migrate to the new syntax. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi StyleX team 👋
First of all, thank you for your ongoing work on StyleX — it's been a great tool to work with!
I have a question regarding media query syntax and current best practices. In the v0.12.0 release notes, it was stated that:
A new rule has been added to the StyleX ESLint plugin to flag uses of the deprecated media query and pseudo-class syntax... This pattern is deprecated and should be replaced with the updated syntax...
However, in the v0.13.0 release blog, the example for using defineConsts seems to still use the legacy pattern where multiple property values are wrapped inside a single media query block.
This leaves me a bit confused about which syntax is currently recommended for media queries. Should we now avoid the legacy @media block pattern entirely? Or is it still supported in certain cases, such as when using defineConsts?
Also, is there any intention to continue supporting the legacy syntax alongside the new one, or should we aim to fully migrate?
Thanks in advance for the clarification!
Beta Was this translation helpful? Give feedback.
All reactions