Exit early in set.issubset

stepancheg · facebook-github-bot · commit 8b10af2c72ae · 2024-10-02T10:56:07.000-07:00
Reviewed By: perehonchuk

Differential Revision: D63740277

fbshipit-source-id: 23b31d2ff39b0d182f2078e2912cac6dd232b195
diff --git a/starlark/src/values/types/set/methods.rs b/starlark/src/values/types/set/methods.rs
@@ -377,7 +377,7 @@ pub(crate) fn set_methods(builder: &mut MethodsBuilder) {
             return Ok(true);
         }
         let rhs = SetFromValue::from_value(other, heap)?;
-        if rhs.is_empty() {
+        if this.aref.content.len() > rhs.get().len() {
             return Ok(false);
         }
         for elem in this.aref.content.iter_hashed() {

Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,7 @@ pub(crate) fn set_methods(builder: &mut MethodsBuilder) {`
`377`	`377`	`return Ok(true);`
`378`	`378`	`}`
`379`	`379`	`let rhs = SetFromValue::from_value(other, heap)?;`
`380`		`- if rhs.is_empty() {`
	`380`	`+ if this.aref.content.len() > rhs.get().len() {`
`381`	`381`	`return Ok(false);`
`382`	`382`	`}`
`383`	`383`	`for elem in this.aref.content.iter_hashed() {`