Skip to content

Commit 4d71985

Browse files
stepanchegfacebook-github-bot
authored andcommitted
Make AbstractType less public
Summary: It is not needed in public API, but because some `Canonical = ...` point to it, Rust requires it to be public. Reviewed By: JakobDegen Differential Revision: D63791951 fbshipit-source-id: 713e75fe49401409c9086f3fd9a691e43b98d7a9
1 parent 9436929 commit 4d71985

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

starlark/src/values/types/starlark_value_as_type.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ use crate::values::layout::avalue::AValueImpl;
3838
use crate::values::layout::heap::repr::AValueRepr;
3939
use crate::values::type_repr::StarlarkTypeRepr;
4040
use crate::values::typing::ty::AbstractType;
41+
use crate::values::typing::TypeType;
4142
use crate::values::AllocFrozenValue;
4243
use crate::values::AllocValue;
4344
use crate::values::FrozenHeap;
@@ -153,10 +154,10 @@ impl<T: StarlarkTypeRepr> StarlarkValueAsType<T> {
153154
}
154155

155156
impl<T: StarlarkTypeRepr> StarlarkTypeRepr for StarlarkValueAsType<T> {
156-
type Canonical = <AbstractType as StarlarkTypeRepr>::Canonical;
157+
type Canonical = <TypeType as StarlarkTypeRepr>::Canonical;
157158

158159
fn starlark_type_repr() -> Ty {
159-
AbstractType::starlark_type_repr()
160+
<Self::Canonical as StarlarkTypeRepr>::starlark_type_repr()
160161
}
161162
}
162163

starlark/src/values/typing/ty.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ use crate::typing::TyBasic;
2626
use crate::values::StarlarkValue;
2727

2828
/// Type of type.
29+
#[doc(hidden)]
2930
#[derive(
3031
Debug,
3132
derive_more::Display,

0 commit comments

Comments
 (0)