StarlarkValue::get_starlark_type_repr return TyStarlarkValue by default

Summary: Types defined with rust code are based on `StarlarkValue` with this diff by default.

Reviewed By: ianlevesque

Differential Revision: D48935231

fbshipit-source-id: 0949f850c8d3896b1cb9099c14fa35276e8cf9d1

Author: stepancheg

starlark/src/values/traits.rs

@@ -248,8 +248,7 @@ pub trait StarlarkValue<'v>:
     /// This can be only implemented by the [`#[starlark_value]`](crate::values::starlark_value)
     /// proc macro.
     fn get_type_starlark_repr() -> Ty {
-        // TODO(nga): replace with `Ty::starlark_value::<Self>()`.
-        Ty::name_static(Self::TYPE)
+        Ty::starlark_value::<Self>()
     }
 
     /// Please do not implement this method or `get_type`,

starlark/src/values/types/dict/value.rs

@@ -497,6 +497,10 @@ where
     fn typechecker_ty(&self) -> Option<Ty> {
         Some(Ty::any_dict())
     }
+
+    fn get_type_starlark_repr() -> Ty {
+        Ty::any_dict()
+    }
 }
 
 impl<'v, T: DictLike<'v>> Serialize for DictGen<T> {

starlark/src/values/types/list/value.rs

@@ -544,6 +544,10 @@ where
     fn typechecker_ty(&self) -> Option<Ty> {
         Some(Ty::any_list())
     }
+
+    fn get_type_starlark_repr() -> Ty {
+        Ty::any_list()
+    }
 }
 
 impl<'v, T: ListLike<'v>> Serialize for ListGen<T> {

starlark/src/values/types/starlark_value_as_type.rs

@@ -198,7 +198,7 @@ def g(x: CompilerArgs): pass
 def h():
     g([])
 "#,
-            r#"Expected type `"compiler_args"` but got"#,
+            r#"Expected type `compiler_args` but got"#,
         );
     }
 

starlark/src/values/types/tuple/value.rs

@@ -259,6 +259,10 @@ where
     fn typechecker_ty(&self) -> Option<Ty> {
         Some(Ty::any_tuple())
     }
+
+    fn get_type_starlark_repr() -> Ty {
+        Ty::any_tuple()
+    }
 }
 
 impl<'v, V: ValueLike<'v>> Serialize for TupleGen<V> {