Skip to content

Commit 9f33746

Browse files
quark-zjufacebook-github-bot
authored andcommitted
histedit: do not show revision numbers
Summary: With segments backend, the revision numbers will be longer than commit hashes and are confusing. Reviewed By: DurhamG Differential Revision: D23408971 fbshipit-source-id: e2057fa644fc7b6be4291f879eee3235bb4e687b
1 parent 96548ca commit 9f33746

10 files changed

+46
-46
lines changed

eden/scm/edenscm/hgext/histedit.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ def torule(self):
486486
"""
487487
ctx = self.repo[self.node]
488488
summary = _getsummary(ctx)
489-
line = "%s %s %d %s" % (self.verb, ctx, ctx.rev(), summary)
489+
line = "%s %s %s" % (self.verb, ctx, summary)
490490
# trim to 75 columns by default so it's not stupidly wide in my editor
491491
# (the 5 more are left for verb)
492492
maxlen = self.repo.ui.configint("histedit", "linelen")

eden/scm/tests/test-fb-hgext-fbhistedit-show-plan.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ show-plan should work
7171
histedit plan (call "histedit --continue/--retry" to resume it or "histedit --abort" to abort it):
7272
exec exit 1
7373
exec exit 2
74-
pick 652413bf663e 5 f
74+
pick 652413bf663e f
7575
exec exit 3
7676

7777
continue should work
@@ -86,7 +86,7 @@ show-plan after consecutive failed execs
8686
$ hg histedit --show-plan
8787
histedit plan (call "histedit --continue/--retry" to resume it or "histedit --abort" to abort it):
8888
exec exit 2
89-
pick 652413bf663e 5 f
89+
pick 652413bf663e f
9090
exec exit 3
9191

9292
continue after consecutive failed execs

eden/scm/tests/test-histedit-arguments.t

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ Run a dummy edit to make sure we get tip^^ correctly via revsingle.
5353
--------------------------------------------------------------------
5454

5555
$ HGEDITOR=cat hg histedit "tip^^"
56-
pick eb57da33312f 2 three
57-
pick c8e68270e35a 3 four
58-
pick 08d98a8350f3 4 five
56+
pick eb57da33312f three
57+
pick c8e68270e35a four
58+
pick 08d98a8350f3 five
5959

6060
# Edit history between eb57da33312f and 08d98a8350f3
6161
#
@@ -287,7 +287,7 @@ Test that trimming description using multi-byte characters
287287
$ hg --encoding utf-8 commit --logfile logfile
288288

289289
$ HGEDITOR=cat hg --encoding utf-8 histedit tip
290-
pick 3d3ea1f3a10b 8 1234567890123456789012345678901234567890123456789012345\xe3\x81\x82... (esc)
290+
pick 3d3ea1f3a10b 1234567890123456789012345678901234567890123456789012345\xe3\x81\x82\xe3\x81\x84... (esc)
291291

292292
# Edit history between 3d3ea1f3a10b and 3d3ea1f3a10b
293293
#
@@ -504,9 +504,9 @@ Test autoverb feature
504504
Check that 'roll' is selected by default
505505

506506
$ HGEDITOR=cat hg histedit 6058cbb6cfd78cfdef42aa56faa272ee45d4b7dc --config experimental.histedit.autoverb=True
507-
pick 6058cbb6cfd7 0 one
508-
roll 4f34d0f8b5fa 2 roll! one
509-
pick 579e40513370 1 two
507+
pick 6058cbb6cfd7 one
508+
roll 4f34d0f8b5fa roll! one
509+
pick 579e40513370 two
510510

511511
# Edit history between 6058cbb6cfd7 and 4f34d0f8b5fa
512512
#

eden/scm/tests/test-histedit-bookmark-motion.t

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@
5757
summary: a
5858

5959
$ HGEDITOR=cat hg histedit 'max(desc(b))'
60-
pick d2ae7f538514 1 b
61-
pick 177f92b77385 2 c
62-
pick 055a42cdd887 3 d
63-
pick e860deea161a 4 e
64-
pick 652413bf663e 5 f
60+
pick d2ae7f538514 b
61+
pick 177f92b77385 c
62+
pick 055a42cdd887 d
63+
pick e860deea161a e
64+
pick 652413bf663e f
6565

6666
# Edit history between d2ae7f538514 and 652413bf663e
6767
#
@@ -117,9 +117,9 @@
117117
summary: a
118118

119119
$ HGEDITOR=cat hg histedit 'max(desc(c))'
120-
pick b346ab9a313d 6 c
121-
pick 59d9f330561f 9 d
122-
pick cacdfd884a93 10 f
120+
pick b346ab9a313d c
121+
pick 59d9f330561f d
122+
pick cacdfd884a93 f
123123

124124
# Edit history between b346ab9a313d and cacdfd884a93
125125
#

eden/scm/tests/test-histedit-commute.t

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ log before edit
5252

5353
show the edit commands offered
5454
$ HGEDITOR=cat hg histedit 177f92b77385
55-
pick 177f92b77385 2 c
56-
pick 055a42cdd887 3 d
57-
pick e860deea161a 4 e
58-
pick 652413bf663e 5 f
55+
pick 177f92b77385 c
56+
pick 055a42cdd887 d
57+
pick e860deea161a e
58+
pick 652413bf663e f
5959

6060
# Edit history between 177f92b77385 and 652413bf663e
6161
#
@@ -332,9 +332,9 @@ Verify that revsetalias entries work with histedit:
332332
$ echo extra commit >> c
333333
$ hg ci -m 'extra commit to c'
334334
$ HGEDITOR=cat hg histedit 'grandparent(.)'
335-
pick ece0b8d93dda 16 c
336-
pick 803ef1c6fcfd 17 e
337-
pick 9c863c565126 18 extra commit to c
335+
pick ece0b8d93dda c
336+
pick 803ef1c6fcfd e
337+
pick 9c863c565126 extra commit to c
338338

339339
# Edit history between ece0b8d93dda and 9c863c565126
340340
#

eden/scm/tests/test-histedit-edit.t

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ Attempting to fold a change into a public change should not work:
394394
hg: parse error: first changeset cannot use verb "fold"
395395
[255]
396396
$ cat .hg/histedit-last-edit.txt
397-
fold 0012be4a27ea 3 extend a
397+
fold 0012be4a27ea extend a
398398

399399
# Edit history between 0012be4a27ea and 0012be4a27ea
400400
#

eden/scm/tests/test-histedit-fold.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,8 +237,8 @@ tip before edit
237237
> pick 1ddb6c90f2ee e
238238
> fold 10c36dd37515 f
239239
> EOF
240-
progress: editing: pick 1ddb6c90f2ee 4 e 1/2 changes (50.00%)
241-
progress: editing: fold 10c36dd37515 6 f 2/2 changes (100.00%)
240+
progress: editing: pick 1ddb6c90f2ee e 1/2 changes (50.00%)
241+
progress: editing: fold 10c36dd37515 f 2/2 changes (100.00%)
242242
progress: editing (end)
243243

244244
tip after edit, which should use the later date, from the second changeset

eden/scm/tests/test-histedit-mutation.t

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,11 @@ Base setup for the rest of the testing
144144

145145

146146
$ HGEDITOR=cat hg histedit 1
147-
pick d2ae7f538514 1 b
148-
pick 177f92b77385 2 c
149-
pick 055a42cdd887 3 d
150-
pick e860deea161a 4 e
151-
pick 652413bf663e 5 f
147+
pick d2ae7f538514 b
148+
pick 177f92b77385 c
149+
pick 055a42cdd887 d
150+
pick e860deea161a e
151+
pick 652413bf663e f
152152

153153
# Edit history between d2ae7f538514 and 652413bf663e
154154
#

eden/scm/tests/test-histedit-no-change.t

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ editing a changeset without any actual change would corrupt the repository
8686

8787
$ startediting 2 3 "(not changing anything)" # edit the 2nd of 3 changesets
8888
% start editing the history (not changing anything)
89-
| pick 055a42cdd887 3 d
90-
| edit e860deea161a 4 e
91-
| pick 652413bf663e 5 f
89+
| pick 055a42cdd887 d
90+
| edit e860deea161a e
91+
| pick 652413bf663e f
9292
0 files updated, 0 files merged, 2 files removed, 0 files unresolved
9393
Editing (e860deea161a), you may commit or record as needed now.
9494
(hg histedit --continue to resume)
@@ -137,9 +137,9 @@ check state of working copy
137137

138138
$ startediting 1,2 3 "(not changing anything)" # edit the 1st two of 3 changesets
139139
% start editing the history (not changing anything)
140-
| edit 055a42cdd887 3 d
141-
| edit e860deea161a 4 e
142-
| pick 652413bf663e 5 f
140+
| edit 055a42cdd887 d
141+
| edit e860deea161a e
142+
| pick 652413bf663e f
143143
0 files updated, 0 files merged, 3 files removed, 0 files unresolved
144144
Editing (055a42cdd887), you may commit or record as needed now.
145145
(hg histedit --continue to resume)
@@ -207,7 +207,7 @@ aborting and not changing files can skip mentioning updating (no) files
207207
$ hg commit -m 'closebranch' --config ui.allowemptycommit=1
208208
$ startediting 1 1 "(not changing anything)" # edit the 3rd of 3 changesets
209209
% start editing the history (not changing anything)
210-
| edit 663c31f74acc 7 closebranch
210+
| edit 663c31f74acc closebranch
211211
Editing (663c31f74acc), you may commit or record as needed now.
212212
(hg histedit --continue to resume)
213213
$ hg histedit --abort

eden/scm/tests/test-histedit-outgoing.t

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@
3636
show the edit commands offered by outgoing
3737
$ cd r2
3838
$ HGEDITOR=cat hg histedit --outgoing ../r | grep -v comparing | grep -v searching
39-
pick 055a42cdd887 3 d
40-
pick e860deea161a 4 e
41-
pick 652413bf663e 5 f
39+
pick 055a42cdd887 d
40+
pick e860deea161a e
41+
pick 652413bf663e f
4242

4343
# Edit history between 055a42cdd887 and 652413bf663e
4444
#
@@ -71,9 +71,9 @@ show the error from unrelated repos
7171
comparing with ../r
7272
searching for changes
7373
warning: repository is unrelated
74-
pick 2a4042b45417 0 g
75-
pick 68c46b4927ce 1 h
76-
pick 51281e65ba79 2 i
74+
pick 2a4042b45417 g
75+
pick 68c46b4927ce h
76+
pick 51281e65ba79 i
7777

7878
# Edit history between 2a4042b45417 and 51281e65ba79
7979
#

0 commit comments

Comments
 (0)