Skip to content

Commit f6ce4ad

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Remove unused-but-set variables in proxygen/lib/http/session/HTTPSession.cpp +1
Summary: Required for LLVM-19 upgrade. This diff removes a variable that was set, but which was not used. LLVM-19 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance. Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging. For questions/comments, contact r-barnes. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: hanidamlaj Differential Revision: D64996211 fbshipit-source-id: db6b587bd9ff7662577f6aaac2ace6dc461cecfc
1 parent 0246ae3 commit f6ce4ad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

proxygen/lib/http/session/HTTPSession.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,7 @@ void HTTPSession::onHeadersComplete(HTTPCodec::StreamID streamID,
896896
// Inform observers when request headers (i.e. ingress, from downstream
897897
// client) are processed.
898898
if (isDownstream()) {
899-
if (auto msgPtr = msg.get()) {
899+
if (msg.get()) {
900900
const auto event =
901901
HTTPSessionObserverInterface::RequestStartedEvent::Builder()
902902
.setTimestamp(HTTPSessionObserverInterface::Clock::now())

0 commit comments

Comments
 (0)