Skip to content

Commit d1900f8

Browse files
Joanna Jofacebook-github-bot
Joanna Jo
authored andcommitted
Mark onIngress as noexcept in HTTP2Codec
Summary: Marking `onIngress()` as `noexcept` in HTTP2Codec for documentation purposes since the caller is invoking `onIngress()` in a `noexcept` context as well. Reviewed By: hanidamlaj Differential Revision: D74289818 fbshipit-source-id: bf5b2b6efe7330cf72e1125fe88250fa0afed4bd
1 parent f805224 commit d1900f8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

proxygen/lib/http/codec/HTTP2Codec.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ HTTP2Codec::~HTTP2Codec() {
5454

5555
// HTTPCodec API
5656

57-
size_t HTTP2Codec::onIngress(const folly::IOBuf& buf) {
57+
size_t HTTP2Codec::onIngress(const folly::IOBuf& buf) noexcept {
5858
// TODO: ensure only 1 parse at a time on stack.
5959
FOLLY_SCOPED_TRACE_SECTION("HTTP2Codec - onIngress");
6060

proxygen/lib/http/codec/HTTP2Codec.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class HTTP2Codec
4646
return userAgent_;
4747
}
4848

49-
size_t onIngress(const folly::IOBuf& buf) override;
49+
size_t onIngress(const folly::IOBuf& buf) noexcept override;
5050
bool onIngressUpgradeMessage(const HTTPMessage& msg) override;
5151
size_t generateConnectionPreface(folly::IOBufQueue& writeBuf) override;
5252
void generateHeader(

0 commit comments

Comments
 (0)