Skip to content

Commit 0777795

Browse files
edwinsmithfacebook-github-bot
authored andcommitted
use logging function name comparator for Debug.TraceFunctions
Summary: use fstrcmp_slice(), which logs case collisions, instead of bstrcaseeq() since we are comparing function names Reviewed By: ricklavoie Differential Revision: D52943301 fbshipit-source-id: 1ef5b54561ba8a8f413a1b3ce1cf5fdef2fb0495
1 parent c914d92 commit 0777795

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

hphp/runtime/vm/jit/mcgen-translate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ CompactVector<Trace::BumpRelease> bumpTraceFunctions(const Func* func) {
104104
if (it == RuntimeOption::TraceFunctions.end()) return opt();
105105
folly::StringPiece name = *it;
106106
if (name.size() >= funcName.size() &&
107-
bstrcaseeq(name.data(), funcName.data(), funcName.size())) {
107+
fstrcmp_slice(funcName, name.subpiece(0, funcName.size())) == 0) {
108108
if (name.size() == funcName.size()) return def();
109109
if (name[funcName.size()] != ';') return opt();
110110
name.advance(funcName.size() + 1);

0 commit comments

Comments
 (0)