Template deserialize with kube resources and custom

[paulcb1]

Hi guys,

I have a template which contains definitions for normal Kube resources as well as 1 custom resource.

When I'm loading it, using client.load(stream), it sometimes deserializes the CR as "GenericKubernetesResource", saving its properties in the "additionalProperties", I get my resource list.

Once in a while, seemingly random, as I can't determine a reason, it actually deserializes the custom resource as the defined class, let's call it "MyCustomResource".

This leads to the error: io.fabric8.kubernetes.client.KubernetesClientException: Cannot edit MyCustomResource with visitors, no builder was found.

If I register a custom Kind on the "KubernetesDeserializer", then I always get this error because it never deserializes as "GenericKubernetesResource".

So, the actual question is: is there a reliable way to deserialize all the resources in the template, even if it contains kube as well as custom resources?

EDIT: As a solution, I can registerCustomKind and map the CR kind to "GenericKubernetesResource", but I was wondering if there's a better way.

[shawkins]

This should in part be addressed by #4579 - the client will internally call registerCustomKind if you use the typed api for your resource - client.resources(MyCustomResource.class). After that call you would then see different deserialization behavior. The pr removes this side-effect.

This leads to the error: io.fabric8.kubernetes.client.KubernetesClientException: Cannot edit MyCustomResource with visitors, no builder was found.

What is your full stack here? I just want to make sure it's occurring at an expected place.

[paulcb1]

A little correction to what I wrote above, I call client.load(stream).get() (to get the resource list).

Stacktrace:
io.fabric8.kubernetes.client.KubernetesClientException: Cannot edit with visitors, no builder was found at io.fabric8.kubernetes.client.ResourceHandlerImpl.edit(ResourceHandlerImpl.java:59) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.acceptVisitors(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:292) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.lambda$getItems$1(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:112) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.getItems(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:114) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.resources(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:119) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.getResources(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:124) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.performOperation(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:327) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.get(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:224) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.get(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:62)

[shawkins]

Ok yes that exception is currently expected when resource does not have a builder, but it actually wouldn't take much to make this go away - a builder isn't really required to just change the namespace which is what it's trying to do here. Feel free to open an issue for this.