Skip to content

Commit c3d8719

Browse files
committed
Merge remote-tracking branch 'rhymes/aa-110' into develop
2 parents 02f3de8 + 1d9d553 commit c3d8719

File tree

12 files changed

+81
-60
lines changed

12 files changed

+81
-60
lines changed

.travis.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@ sudo: false
22
language: ruby
33
# Limit ruby versions to currently supported versions to avoid a big build matrix
44
rvm:
5-
- 2.2
6-
- 2.3.0
7-
# Update bundler on travis, since current one is broken, see https://github.com/rubygems/rubygems/issues/1419
8-
before_install:
9-
- gem install bundler
5+
- 2.2.7
6+
- 2.3.4
7+
- 2.4.1
108
# Load database schema before rake
119
before_script: bundle exec rake db:schema:load
1210
# Test on all supported rails versions
1311
gemfile:
14-
- gemfiles/activeadmin_master.gemfile
15-
- gemfiles/rails4_1.gemfile
1612
- gemfiles/rails4_2.gemfile
13+
- gemfiles/rails5_0.gemfile
14+
- gemfiles/rails5_1.gemfile

Appraisals

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
appraise 'rails4_1' do
2-
gem 'rails', '~> 4.1.12'
3-
gem 'globalize', '~> 4.0.3'
1+
appraise 'rails4_2' do
2+
gem 'rails', '~> 4.2.9'
3+
gem 'globalize', '~> 5.0.0'
44
end
55

6-
appraise 'rails4_2' do
7-
gem 'rails', '~> 4.2.3'
6+
appraise 'rails5_0' do
7+
gem 'rails', '~> 4.2.9'
88
gem 'globalize', '~> 5.0.0'
99
end
1010

11-
# Run tests on latest github version of ActiveAdmin
12-
appraise 'activeadmin_master' do
13-
gem 'rails', '~> 4.2.0'
14-
gem 'activeadmin', github: 'activeadmin/activeadmin'
11+
appraise 'rails5_1' do
12+
gem 'devise', '~> 4.3'
13+
gem 'rails', '~> 5.1.3'
14+
gem 'globalize', '~> 5.1.0.beta2'
1515
end

Gemfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ gem 'devise', '~> 3.2'
2929

3030
group :test do
3131
gem 'sqlite3', '~> 1.3.5'
32-
gem 'rspec-rails', '~> 2.14.0'
32+
gem 'rspec-rails', '~> 3.6.1'
3333
gem 'factory_girl_rails', '~> 4.2.1'
3434
gem 'database_cleaner', '~> 1.0.1'
3535
gem 'spring', require: false
3636
gem 'spring-commands-rspec', require: false
37-
gem 'capybara', '~> 2.1.0'
37+
gem 'capybara', '~> 2.15'
3838
gem 'capybara-screenshot'
3939
gem 'poltergeist'
40-
gem 'fuubar'
40+
gem 'fuubar', '~> 2.2'
4141
gem 'appraisal'
4242
# Useful to debug tests
4343
gem 'awesome_print'

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,19 @@ Looking for maintainers. See https://github.com/fabn/activeadmin-globalize/issue
1414
This version targets Rails 4 and greater and ActiveAdmin >= 1.0.0.pre.
1515

1616
```ruby
17-
gem 'activeadmin-globalize', '~> 1.0.0.pre', github: 'fabn/activeadmin-globalize', branch: 'develop'
17+
gem 'activeadmin-globalize', '~> 1.0.0', github: 'fabn/activeadmin-globalize', branch: 'develop'
1818
```
1919

2020
As soon as ActiveAdmin 1.x is released to rubygems, I'll release the gem with no need for github dependency. See
2121
[this issue](https://github.com/activeadmin/activeadmin/issues/3448) for more details.
2222

2323
Previous version with support for Rails 3 is maintained in branch [support/0.6.x](https://github.com/fabn/activeadmin-globalize/tree/support/0.6.x)
2424

25+
## Require Assets
26+
27+
- active_admin.js: `//= require active_admin/active_admin_globalize.js`
28+
- active_admin.css: `*= require active_admin/active_admin_globalize`
29+
2530
## Your model
2631

2732
```ruby
@@ -72,7 +77,7 @@ form do |f|
7277
end
7378

7479
# You can also set locales to show in tabs
75-
# For example we want to show English translation fields without tab, and want to show other languages within tabs
80+
# For example we want to show English translation fields without tab, and want to show other languages within tabs
7681
form do |f|
7782
# ...
7883
f.inputs do

activeadmin-globalize.gemspec

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ Gem::Specification.new do |s|
1111
s.email = ['stefano.verna@gmail.com', 'f.napoleoni@gmail.com']
1212
s.homepage = 'http://github.com/fabn/activeadmin-globalize'
1313
s.summary = 'Handles globalize translations'
14-
s.description = 'Handles globalize translations in ActiveAdmin 0.6.3 and Rails 3.2.x'
14+
s.description = 'Handles globalize translations in ActiveAdmin 1.0 and Rails 4.x-5.x'
1515

1616
s.files = Dir['{app,config,db,lib}/**/*'] + %w(MIT-LICENSE README.md)
1717

18-
s.add_dependency 'activeadmin', '~> 1.0.0.pre'
18+
s.add_dependency 'activeadmin', '>= 1.0', '< 1.2'
1919
# Try to support rails from 3.2 up to 4.2.x
2020
s.add_dependency 'globalize', '>= 3.1.0', '< 6.0'
2121

@@ -25,4 +25,3 @@ Gem::Specification.new do |s|
2525
# Other development dependencies moved into Gemfile
2626

2727
end
28-

app/assets/stylesheets/active_admin/active_admin_globalize.sass

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
@import "active_admin/mixins"
2-
2+
@import "active_admin_globalize_mixins"
33
@import "active_admin_globalize_flags"
44

55
.active_admin
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
@mixin border-top-radius($radius)
2+
-webkit-border-top-right-radius: $radius
3+
border-top-right-radius: $radius
4+
-webkit-border-top-left-radius: $radius
5+
border-top-left-radius: $radius
6+
background-clip: padding-box
7+
8+
@mixin border-right-radius($radius)
9+
-webkit-border-bottom-right-radius: $radius
10+
border-bottom-right-radius: $radius
11+
-webkit-border-top-right-radius: $radius
12+
border-top-right-radius: $radius
13+
background-clip: padding-box
14+
15+
@mixin border-bottom-radius($radius)
16+
-webkit-border-bottom-right-radius: $radius
17+
border-bottom-right-radius: $radius
18+
-webkit-border-bottom-left-radius: $radius
19+
border-bottom-left-radius: $radius
20+
background-clip: padding-box
21+
22+
@mixin border-left-radius($radius)
23+
-webkit-border-bottom-left-radius: $radius
24+
border-bottom-left-radius: $radius
25+
-webkit-border-top-left-radius: $radius
26+
border-top-left-radius: $radius
27+
background-clip: padding-box

gemfiles/rails4_2.gemfile

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@ source "https://rubygems.org"
44

55
gem "sass-rails"
66
gem "coffee-rails"
7-
gem "therubyracer", :platforms => :ruby
7+
gem "therubyracer", platforms: :ruby
88
gem "uglifier"
99
gem "jquery-rails"
1010
gem "devise", "~> 3.2"
11-
gem "rails", "~> 4.2.3"
11+
gem "rails", "~> 4.2.9"
1212
gem "globalize", "~> 5.0.0"
1313

1414
group :test do
1515
gem "sqlite3", "~> 1.3.5"
16-
gem "rspec-rails", "~> 2.14.0"
16+
gem "rspec-rails", "~> 3.6.1"
1717
gem "factory_girl_rails", "~> 4.2.1"
1818
gem "database_cleaner", "~> 1.0.1"
19-
gem "spring", :require => false
20-
gem "spring-commands-rspec", :require => false
21-
gem "capybara", "~> 2.1.0"
19+
gem "spring", require: false
20+
gem "spring-commands-rspec", require: false
21+
gem "capybara", "~> 2.15"
2222
gem "capybara-screenshot"
2323
gem "poltergeist"
24-
gem "fuubar"
24+
gem "fuubar", "~> 2.2"
2525
gem "appraisal"
2626
gem "awesome_print"
2727
gem "pry"
2828
end
2929

30-
gemspec :path => "../"
30+
gemspec path: "../"

gemfiles/rails4_1.gemfile renamed to gemfiles/rails5_0.gemfile

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@ source "https://rubygems.org"
44

55
gem "sass-rails"
66
gem "coffee-rails"
7-
gem "therubyracer", :platforms => :ruby
7+
gem "therubyracer", platforms: :ruby
88
gem "uglifier"
99
gem "jquery-rails"
1010
gem "devise", "~> 3.2"
11-
gem "rails", "~> 4.1.12"
12-
gem "globalize", "~> 4.0.3"
11+
gem "rails", "~> 4.2.9"
12+
gem "globalize", "~> 5.0.0"
1313

1414
group :test do
1515
gem "sqlite3", "~> 1.3.5"
16-
gem "rspec-rails", "~> 2.14.0"
16+
gem "rspec-rails", "~> 3.6.1"
1717
gem "factory_girl_rails", "~> 4.2.1"
1818
gem "database_cleaner", "~> 1.0.1"
19-
gem "spring", :require => false
20-
gem "spring-commands-rspec", :require => false
21-
gem "capybara", "~> 2.1.0"
19+
gem "spring", require: false
20+
gem "spring-commands-rspec", require: false
21+
gem "capybara", "~> 2.15"
2222
gem "capybara-screenshot"
2323
gem "poltergeist"
24-
gem "fuubar"
24+
gem "fuubar", "~> 2.2"
2525
gem "appraisal"
2626
gem "awesome_print"
2727
gem "pry"
2828
end
2929

30-
gemspec :path => "../"
30+
gemspec path: "../"

gemfiles/activeadmin_master.gemfile renamed to gemfiles/rails5_1.gemfile

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@ source "https://rubygems.org"
44

55
gem "sass-rails"
66
gem "coffee-rails"
7-
gem "therubyracer", :platforms => :ruby
7+
gem "therubyracer", platforms: :ruby
88
gem "uglifier"
99
gem "jquery-rails"
10-
gem "devise", "~> 3.2"
11-
gem "rails", "~> 4.2.0"
12-
gem "activeadmin", :github => "activeadmin/activeadmin"
10+
gem "devise", "~> 4.3"
11+
gem "rails", "~> 5.1.3"
12+
gem "globalize", "~> 5.1.0.beta2"
1313

1414
group :test do
1515
gem "sqlite3", "~> 1.3.5"
16-
gem "rspec-rails", "~> 2.14.0"
16+
gem "rspec-rails", "~> 3.6.1"
1717
gem "factory_girl_rails", "~> 4.2.1"
1818
gem "database_cleaner", "~> 1.0.1"
19-
gem "spring", :require => false
20-
gem "spring-commands-rspec", :require => false
21-
gem "capybara", "~> 2.1.0"
19+
gem "spring", require: false
20+
gem "spring-commands-rspec", require: false
21+
gem "capybara", "~> 2.15"
2222
gem "capybara-screenshot"
2323
gem "poltergeist"
24-
gem "fuubar"
24+
gem "fuubar", "~> 2.2"
2525
gem "appraisal"
2626
gem "awesome_print"
2727
gem "pry"
2828
end
2929

30-
gemspec :path => "../"
30+
gemspec path: "../"

0 commit comments

Comments
 (0)