Change color to red if the personal access token is invalid

[vfonic]

I just tried setting invalid github token and realized that I didn't get any errors back.

This happens here:
https://github.com/fabiospampinato/vscode-github-notifications-bell/blob/master/src/statusbar.ts#L70

When API token is correct, the response is an array of notifications:
JSON.parse ( result[0].body ) // => [{...}, {...}]

When API token is incorrect, the response is an object:
JSON.parse ( result[0].body ) // => {"message":"Bad credentials","documentation_url":"https://developer.github.com/v3"}

It would be useful for user to know that they didn't set the token right.

[fabiospampinato]

The problem with displaying all errors is that we might hit the API limit, and in that situation we don't want to spam the user with notifications 🤔

Maybe let's just add an error notification for "bad credentials" errors 👍

[vfonic]

🤔 Maybe you're right. Maybe most of the users will generate the token only for this and never hit API limit.

In any case, as a user, I'd definitely prefer to see an error than to see the default icon, which means "no notifications".

Perhaps a red icon if there's an error? :)
That plus a tooltip might be the best solution.

I won't be able to work on this feature. Hopefully someone can take over.

[fabiospampinato]

Maybe most of the users will generate the token only for this and never hit API limit.

I did hit the limits in the past, it depends also on what refresh interval one sets.

Perhaps a red icon if there's an error? :)

👍