reafactor: fix some review points like file.Stream function

Author: fabiodcorreia

Makefile

@@ -7,8 +7,6 @@ NAME = CatchMyFile
 
 TARGET = pkg/**/*.go
 
-#@dupl -t 30 $(TARGET)
-
 format:
 	@gofmt -s -w $(TARGET)
 

pkg/file/file.go

@@ -38,6 +38,10 @@ func Stream(ctx context.Context, in io.Reader, out io.Writer, onProg OnProgressC
 		return -1, fmt.Errorf("file stream error: output writer is nil")
 	}
 
+	return stream(ctx, in, out, onProg)
+}
+
+func stream(ctx context.Context, in io.Reader, out io.Writer, onProg OnProgressChange) (int, error) {
 	var transferred int
 	buf := make([]byte, transferChunkSize)
 	for {

pkg/transfer/receiver.go

@@ -128,7 +128,11 @@ func handleRequest(ctx context.Context, conn net.Conn, store *TransferStore) {
 	trans.Status = Verifying
 	store.Update(id, trans)
 
-	f, err := file.Open(trans.LocalFilePath, file.OPEN_READ)
+	verifyFile(ctx, trans, rcvSize, id, store)
+}
+
+func verifyFile(ctx context.Context, t *Transfer, rcvSize, id int, store *TransferStore) {
+	f, err := file.Open(t.LocalFilePath, file.OPEN_READ)
 	if err != nil {
 		clog.Error(err)
 	}
@@ -139,13 +143,13 @@ func handleRequest(ctx context.Context, conn net.Conn, store *TransferStore) {
 		}
 	}()
 
-	if err = verifyTransfer(ctx, trans, rcvSize, f); err != nil {
-		trans.SetError(err)
+	if err = verifyTransfer(ctx, t, rcvSize, f); err != nil {
+		t.SetError(err)
 	} else {
-		trans.Status = Completed
+		t.Status = Completed
 	}
 
-	store.Update(id, trans)
+	store.Update(id, t)
 }
 
 // reqDecisionAndWait will add the transfer to the store and wait for confirmation

pkg/transfer/view.go

@@ -122,7 +122,7 @@ func (tl *TransferList) updateItem(i widget.ListItemID, item fyne.CanvasObject)
 	if t.Status == Error && t.Error() != nil {
 		dialog.ShowError(t.Error(), tl.Parent)
 
-		//! Realy don't like this
+		//! Really don't like this
 		go func() {
 			t.err = nil
 			tl.store.Update(i, t)