Double check disabled cops from last major upgrade

[sagotsky]

#102 disabled a number of cops so we could move forward with a major upgrade. Let's loop back and make sure we didn't miss anything good.

• Layout/BeginEndAlignment:
• Layout/EmptyLinesAroundAttributeAccessor:
• Layout/IndentationStyle:
• Layout/SpaceAroundMethodCallOperator:
• Lint/BinaryOperatorWithIdenticalOperands:
• Lint/ConstantDefinitionInBlock:
• Lint/DeprecatedOpenSSLConstant:
• Lint/DuplicateElsifCondition:
• Lint/DuplicateRequire:
• Lint/DuplicateRescueException:
• Lint/EmptyConditionalBody:
• Lint/EmptyFile:
• Lint/FloatComparison:
• Lint/HashCompareByIdentity:
• Lint/IdentityComparison:
• Lint/MissingSuper:
• Lint/MixedRegexpCaptureTypes:
• Lint/OutOfRangeRegexpRef:
• Lint/RaiseException:
• Lint/RedundantSafeNavigation:
• Lint/SelfAssignment:
• Lint/TopLevelReturnWithArgument:
• Lint/TrailingCommaInAttributeDeclaration:
• Lint/UnreachableLoop:
• Lint/UselessMethodDefinition:
• Lint/UselessTimes:
• Rails/ArelStar:
• Rails/Pick:
• Rails/RedundantForeignKey:
• RSpec/Capybara/CurrentPathExpectation:
• RSpec/Capybara/FeatureMethods:
• RSpec/Capybara/VisibilityMatcher:
• RSpec/EmptyHook:
• RSpec/FactoryBot/AttributeDefinedStatically:
• RSpec/FactoryBot/CreateList:
• RSpec/FactoryBot/FactoryClassName:
• RSpec/MultipleMemoizedHelpers:
• RSpec/NotToNot:
• RSpec/Rails/HttpStatus:
• RSpec/RepeatedIncludeExample:
• RSpec/StubbedMock:
• RSpec/VariableDefinition:
• RSpec/VariableName:
• Style/AccessorGrouping:
• Style/BisectedAttrAccessor:
• Style/CaseLikeIf:
• Style/CombinableLoops:
• Style/ExponentialNotation:
• Style/GlobalStdStream:
• Style/HashAsLastArrayItem:
• Style/HashLikeCase:
• Style/KeywordParametersOrder:
• Style/OptionalBooleanParameter:
• Style/RedundantAssignment:
• Style/RedundantRegexpCharacterClass:
• Style/RedundantRegexpEscape:
• Style/RedundantSelfAssignment:
• Style/SingleArgumentDig:
• Style/SlicingWithRange:
• Style/SoleNestedConditional:

[jaeger401]

Clarifying that these are all for ez-rails. Other repos may have different sets of disabled cops as we roll out, right? I suppose that we can defer many of those to application owners though.

[sagotsky]

Correct! I'll spot check a couple other repos as well.

I don't think we're obligated to have 0 new violations in this update. But the new violations should be manageable.

[jmpage]

Aren't these cops globally disabled for every repo using ezcater_rubocop in #102?: https://github.com/ezcater/ezcater_rubocop/pull/102/files#diff-c66a88fa9e93cc802b88ebc30bd2496d933cdb11a3ba4d904813466f3c7f2350

[sagotsky]

Yes, same list. I think we should come back and re-evaluate disabling them after this goes out.