Skip to content

[LTS] Proposal: Update engines Field to Reflect Dropped Support for Node.js 6.x and 8.x #1305

@UlisesGascon

Description

@UlisesGascon

Recently, we introduced a CI pipeline for the lts branch (see #1302). However, it appears that the CI is currently failing due to issues with busboy@1.0.0 on both Node.js 8.x and Node.js 6.x.

> multer@1.4.5-lts.2 test /home/runner/work/multer/multer
> mocha --reporter spec --exit --check-leaks test/


/home/runner/work/multer/multer/node_modules/busboy/lib/utils.js:469
    } catch {}
            ^

SyntaxError: Unexpected token {

As noted, busboy@1.0.0 has a minimum Node.js support of >=10.16 (reference). Based on this, it seems that support for Node.js 6.x and 8.x has effectively been dropped. However, our engines field is still defined as "node": ">= 6.0.0" (reference).

Given this, I would like to propose updating the engines field to accurately reflect the new minimum supported Node.js version. Since this dependency update was introduced as part of a security patch (reference1, reference2), I believe it is reasonable to formally drop support for older Node.js versions (as has effectively already occurred), and treat this as a minor or patch-level semver update.

As this change may be considered an exception to our current ADR policy (see here), I would like to request feedback and guidance from the @expressjs/express-tc team on how best to proceed.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions