From 69d35072fbadea7aead71398f3df8298246ddaa6 Mon Sep 17 00:00:00 2001 From: Ville Vesilehto Date: Sat, 1 Mar 2025 22:18:54 +0200 Subject: [PATCH] ci: pin benchstat version and update GitHub Actions Fix CI workflow compatibility issues and update dependencies: - Pin benchstat to specific commit (884df5) compatible with Go 1.18 instead of using @latest which now requires Go 1.23+ - Add explanatory comment about benchstat version constraints - Upgrade actions/upload-artifact from v3 to v4 in fuzz.yml - Upgrade github/codeql-action from v2 to v3 in fuzz.yml These changes ensure the CI pipeline remains compatible with Go 1.18 while benefiting from the latest improvements in GitHub Actions. Signed-off-by: Ville Vesilehto --- .github/workflows/diff.yml | 4 +++- .github/workflows/fuzz.yml | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/diff.yml b/.github/workflows/diff.yml index d9fd20c59..3a81ba2e1 100644 --- a/.github/workflows/diff.yml +++ b/.github/workflows/diff.yml @@ -13,7 +13,9 @@ jobs: with: go-version: 1.18 - name: Install benchstat - run: go install golang.org/x/perf/cmd/benchstat@latest + # NOTE: benchstat@latest requires go 1.23 since 2025-02-14 - this is the last go 1.18 ref + # https://cs.opensource.google/go/x/perf/+/c95ad7d5b636f67d322a7e4832e83103d0fdd292 + run: go install golang.org/x/perf/cmd/benchstat@884df5810d2850d775c2cb4885a7ea339128a17d - uses: actions/checkout@v3 - name: Benchmark new code diff --git a/.github/workflows/fuzz.yml b/.github/workflows/fuzz.yml index b883b8393..34e77d6be 100644 --- a/.github/workflows/fuzz.yml +++ b/.github/workflows/fuzz.yml @@ -21,14 +21,14 @@ jobs: fuzz-seconds: 600 output-sarif: true - name: Upload Crash - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: failure() && steps.build.outcome == 'success' with: name: artifacts path: ./out/artifacts - name: Upload Sarif if: always() && steps.build.outcome == 'success' - uses: github/codeql-action/upload-sarif@v2 + uses: github/codeql-action/upload-sarif@v3 with: # Path to SARIF file relative to the root of the repository sarif_file: cifuzz-sarif/results.sarif