why read twice in newConnection?

[donnol]

func newConnection(d *driver) (*connection, error) {
	c := &connection{}
	c.close()
	conn, err := net.Dial("tcp", fmt.Sprintf("%s:%d", d.Host, d.Port))
	if err != nil {
		return nil, err
	}

	c.closed = false
	c.conn = conn
	c.reader = bufio.NewReader(c.conn)

	err = c.write(fmt.Sprintf("START %s %s", d.channel, d.Password))
	if err != nil {
		return nil, err
	}

	// what is the purpose?
	_, err = c.read()
	_, err = c.read()
	if err != nil {
		return nil, err
	}
	return c, nil
}

[timurgarif]

The first call to c.read() reads CONNECTED <sonic-server vX.Y.Z> line.
The second call reads STARTED search protocol(1) buffer(20000) - the response line to START chan pswd

[donnol]

@timurgarif Ok, thanks.

But ignoring the err check between the twice read should cause problem if the first read return a err not nil.

[alexisvisco]

Yes, there is a project of adding some pooling and rewrite the connection mechanism.

For now, I am a little bit busy but maybe the next week I will be working on it.

[donnol]

That's great, thanks.

Yes, there is a project of adding some pooling and rewrite the connection mechanism.

For now, I am a little bit busy but maybe the next week I will be working on it.

[krokite]

Any update on the bug?