review comments

Author: roberto-bayardo

Cargo.toml

@@ -26,7 +26,7 @@ url = "2.5.2"
 futures-util = "0.3.30"
 serde = "1.0.219"
 serde_json = "1.0.120"
-serde_with = { version = "3.0", features = ["base64"] }
+serde_with = { version = "3.14.0" }
 tempfile = "3.10.1"
 portpicker = "0.1.1"
 http = "1.3.1"

sdk-rs/Cargo.toml

@@ -16,7 +16,7 @@ futures-util = { workspace = true }
 http = { workspace = true }
 reqwest = { workspace = true, features = ["json"] }
 serde = { workspace = true, features = ["derive"] }
-serde_with = { workspace = true }
+serde_with = { workspace = true, features = ["base64"] }
 serde_json = { workspace = true }
 thiserror = { workspace = true }
 tokio = { workspace = true, features = ["full"] }

sdk-ts/src/store.ts

@@ -64,8 +64,8 @@ export class StoreClient {
         const encodedKey = Base64.fromUint8Array(key);
         const url = `${this.client.baseUrl}/store/${encodedKey}`;
         try {
-            const response = await this.client.httpClient.get<{ value: number[] }>(url);
-            const value = new Uint8Array(response.data.value);
+            const response = await this.client.httpClient.get<{ value: string }>(url);
+            const value = Base64.toUint8Array(response.data.value);
             return { value };
         } catch (error) {
             if (error instanceof AxiosError && error.response) {
@@ -97,10 +97,10 @@ export class StoreClient {
         if (limit) url.searchParams.append('limit', limit.toString());
 
         try {
-            const response = await this.client.httpClient.get<{ results: { key: number[], value: number[] }[] }>(url.toString());
+            const response = await this.client.httpClient.get<{ results: { key: string, value: string }[] }>(url.toString());
             const results = response.data.results.map(item => ({
-                key: new Uint8Array(item.key),
-                value: new Uint8Array(item.value)
+                key: Base64.toUint8Array(item.key),
+                value: Base64.toUint8Array(item.value)
             }));
             return { results };
         } catch (error) {