Reworked more status codes into problem details

Author: niemyjski

src/Exceptionless.Core/Extensions/UserExtensions.cs

@@ -1,4 +1,5 @@
 using Exceptionless.Core.Models;
+using Exceptionless.DateTimeExtensions;
 
 namespace Exceptionless.Core.Extensions;
 
@@ -29,7 +30,7 @@ public static void MarkEmailAddressVerified(this User user)
 
     public static bool HasValidVerifyEmailAddressTokenExpiration(this User user, TimeProvider timeProvider)
     {
-        return user.VerifyEmailAddressTokenExpiration != DateTime.MinValue && user.VerifyEmailAddressTokenExpiration >= timeProvider.GetUtcNow().UtcDateTime;
+        return user.VerifyEmailAddressTokenExpiration.IsAfterOrEqual(timeProvider.GetUtcNow().UtcDateTime);
     }
 
     public static void ResetPasswordResetToken(this User user)

src/Exceptionless.Web/Controllers/AuthController.cs

@@ -163,11 +163,11 @@ public async Task<IActionResult> LogoutAsync()
     {
         using var _ = _logger.BeginScope(new ExceptionlessState().Tag("Logout").Identity(CurrentUser.EmailAddress).SetHttpContext(HttpContext));
         if (User.IsTokenAuthType())
-            return StatusCode(403, "Logout not supported for current user access token");
+            return Forbidden("Logout not supported for current user access token");
 
         string? id = User.GetLoggedInUsersTokenId();
         if (String.IsNullOrEmpty(id))
-            return StatusCode(403, "Logout not supported");
+            return Forbidden("Logout not supported");
 
         try
         {

src/Exceptionless.Web/Controllers/Base/ExceptionlessApiController.cs

@@ -182,9 +182,9 @@ protected bool ShouldApplySystemFilter(AppFilter sf, string? filter)
     protected ObjectResult Permission(PermissionResult permission)
     {
         if (String.IsNullOrEmpty(permission.Message))
-            return StatusCode(permission.StatusCode, null);
+            return Problem(statusCode: permission.StatusCode);
 
-        return StatusCode(permission.StatusCode, new MessageContent(permission.Id, permission.Message));
+        return Problem(statusCode: permission.StatusCode, title: permission.Message);
     }
 
     protected ActionResult<WorkInProgressResult> WorkInProgress(IEnumerable<string> workers)