Skip to content

Commit c147834

Browse files
committed
Added transitions for grids and added loop each identifiers
1 parent 61994f1 commit c147834

File tree

12 files changed

+25
-18
lines changed

12 files changed

+25
-18
lines changed

src/Exceptionless.Web/ClientApp/src/lib/components/DateRangeDropdown.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<Select.Value placeholder="" />
2828
</Select.Trigger>
2929
<Select.Content>
30-
{#each items as item}
30+
{#each items as item (item.label)}
3131
<Select.Item value={item.value}>{item.label}</Select.Item>
3232
{/each}
3333
</Select.Content>

src/Exceptionless.Web/ClientApp/src/lib/components/data-table/data-table-body.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<Table.Header>
3939
{#each $table.getHeaderGroups() as headerGroup}
4040
<Table.Row>
41-
{#each headerGroup.headers as header}
41+
{#each headerGroup.headers as header (header.id)}
4242
<Table.Head class={getHeaderColumnClass(header)}>
4343
<DataTableColumnHeader column={header.column}
4444
><svelte:component this={flexRender(header.column.columnDef.header, header.getContext())} /></DataTableColumnHeader
@@ -52,9 +52,9 @@
5252
<Table.Row class="hidden text-center only:table-row">
5353
<Table.Cell colspan={$table.getVisibleLeafColumns().length}>No data was found with the current filter.</Table.Cell>
5454
</Table.Row>
55-
{#each $table.getRowModel().rows as row}
55+
{#each $table.getRowModel().rows as row (row.id)}
5656
<Table.Row>
57-
{#each row.getVisibleCells() as cell}
57+
{#each row.getVisibleCells() as cell (cell.id)}
5858
<Table.Cell on:click={() => onCellClick(cell)} class={getCellClass(cell)}>
5959
<svelte:component this={flexRender(cell.column.columnDef.cell, cell.getContext())} />
6060
</Table.Cell>

src/Exceptionless.Web/ClientApp/src/lib/components/data-table/data-table-faceted-filter.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
{values.length} Selected
5353
</Badge>
5454
{:else}
55-
{#each values as option}
55+
{#each values as option (option)}
5656
<Badge variant="secondary" class="rounded-sm px-1 font-normal">
5757
{option}
5858
</Badge>
@@ -68,7 +68,7 @@
6868
<Command.List>
6969
<Command.Empty>No results found.</Command.Empty>
7070
<Command.Group>
71-
{#each options as option}
71+
{#each options as option (option.value)}
7272
<Command.Item value={option.value} onSelect={onValueSelected}>
7373
<div
7474
class={cn(

src/Exceptionless.Web/ClientApp/src/lib/components/data-table/data-table-page-size.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<Select.Value placeholder="Select page size" />
4040
</Select.Trigger>
4141
<Select.Content>
42-
{#each items as item}
42+
{#each items as item (item.value)}
4343
<Select.Item value={item.value}>{item.label}</Select.Item>
4444
{/each}
4545
</Select.Content>

src/Exceptionless.Web/ClientApp/src/lib/components/data-table/data-table-view-options.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<DropdownMenu.Content>
2121
<DropdownMenu.Label>Toggle columns</DropdownMenu.Label>
2222
<DropdownMenu.Separator />
23-
{#each $table.getAllLeafColumns() as column}
23+
{#each $table.getAllLeafColumns() as column (column.id)}
2424
{#if column.getCanHide()}
2525
<DropdownMenu.CheckboxItem checked={column.getIsVisible()} on:click={() => column.toggleVisibility()}>
2626
{column.columnDef.header}

src/Exceptionless.Web/ClientApp/src/lib/components/events/EventsDrawer.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,12 @@
153153

154154
<Tabs.Root value={activeTab} class="mb-4 mt-4">
155155
<Tabs.List class="mb-4 w-full justify-normal">
156-
{#each $tabs as tab}
156+
{#each $tabs as tab (tab)}
157157
<Tabs.Trigger value={tab}>{tab}</Tabs.Trigger>
158158
{/each}
159159
</Tabs.List>
160160

161-
{#each $tabs as tab}
161+
{#each $tabs as tab (tab)}
162162
<Tabs.Content value={tab}>
163163
{#if tab === 'Overview'}
164164
<Overview event={$eventResponse.data}></Overview>

src/Exceptionless.Web/ClientApp/src/lib/components/events/views/Overview.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@
162162
<Table.Row>
163163
<Table.Head class="whitespace-nowrap">Tags</Table.Head>
164164
<Table.Cell class="flex flex-wrap justify-start gap-2 overflow-auto">
165-
{#each event.tags as tag}
165+
{#each event.tags as tag (tag)}
166166
<ClickableStringFilter term="tag" value={tag}><Badge color="dark">{tag}</Badge></ClickableStringFilter>
167167
{/each}
168168
</Table.Cell>

src/Exceptionless.Web/ClientApp/src/lib/components/events/views/Request.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@
137137
</Table.Row>
138138
</Table.Header>
139139
<Table.Body>
140-
{#each Object.entries(sortedHeaders) as [key, value]}
140+
{#each Object.entries(sortedHeaders) as [key, value] (key)}
141141
<Table.Row>
142142
<Table.Cell>{key}</Table.Cell>
143143
<Table.Cell><span class="line-clamp-3 inline">{value}</span></Table.Cell>
@@ -157,7 +157,7 @@
157157
</Table.Row>
158158
</Table.Header>
159159
<Table.Body>
160-
{#each Object.entries(request.cookies || {}) as [key, value]}
160+
{#each Object.entries(request.cookies || {}) as [key, value] (key)}
161161
<Table.Row>
162162
<Table.Cell>{key}</Table.Cell>
163163
<Table.Cell><span class="line-clamp-3 inline">{value}</span></Table.Cell>

src/Exceptionless.Web/ClientApp/src/lib/components/ui/table/table-row.svelte

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<script lang="ts">
22
import { cn } from '$lib/utils';
33
import type { HTMLAttributes } from 'svelte/elements';
4+
import { slide } from 'svelte/transition';
45
56
type $$Props = HTMLAttributes<HTMLTableRowElement> & {
67
'data-state'?: unknown;
@@ -10,6 +11,12 @@
1011
export { className as class };
1112
</script>
1213

13-
<tr class={cn('border-b transition-colors hover:bg-muted/50 data-[state=selected]:bg-muted', className)} {...$$restProps} on:click on:keydown>
14+
<tr
15+
class={cn('border-b transition-colors hover:bg-muted/50 data-[state=selected]:bg-muted', className)}
16+
{...$$restProps}
17+
on:click
18+
on:keydown
19+
transition:slide={{ delay: 0, duration: 250, axis: 'y' }}
20+
>
1421
<slot />
1522
</tr>

src/Exceptionless.Web/ClientApp/src/routes/(app)/(components)/NavigationCommand.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
<Command.Input placeholder="Type a command or search..." />
1818
<Command.List>
1919
<Command.Empty>No results found.</Command.Empty>
20-
{#each Object.entries(groupedRoutes) as [group, items], index}
20+
{#each Object.entries(groupedRoutes) as [group, items], index (group)}
2121
<Command.Group heading={group}>
22-
{#each items as route}
22+
{#each items as route (route.href)}
2323
<Command.Item>
2424
<A href={route.href} class="flex gap-x-2" on:click={closeCommandWindow}>
2525
<svelte:component this={route.icon} />

0 commit comments

Comments
 (0)