improved tsconfig strictness

https://www.totaltypescript.com/tsconfig-cheat-sheet

Author: niemyjski

src/Exceptionless.Web/ClientApp/src/lib/features/events/components/views/Request.svelte

@@ -39,7 +39,7 @@
             .sort()
             .reduce(
                 (acc, key) => {
-                    acc[key] = request.headers?.[key].join(',') ?? '';
+                    acc[key] = request.headers?.[key]?.join(',') ?? '';
                     return acc;
                 },
                 {} as Record<string, string>

src/Exceptionless.Web/ClientApp/src/lib/features/events/models/index.ts

@@ -53,6 +53,6 @@ export interface SubmissionClient {
 }
 
 export class PersistentEvent extends PersistentEventBase {
-    @IsOptional() @ValidateNested() data?: IPersistentEventData = undefined;
-    @IsOptional() type?: PersistentEventKnownTypes = undefined;
+    @IsOptional() @ValidateNested() override data?: IPersistentEventData = undefined;
+    @IsOptional() override type?: PersistentEventKnownTypes = undefined;
 }

src/Exceptionless.Web/ClientApp/src/lib/features/shared/components/DateRangeDropdown.svelte

@@ -7,15 +7,16 @@
 
     let { value = $bindable() }: Props = $props();
 
-    const items = [
+    type Item = { label: string; value: string };
+    const items: Item[] = [
         { label: 'Last Hour', value: 'last hour' },
         { label: 'Last 24 Hours', value: 'last 24 hours' },
         { label: 'Last Week', value: 'last week' },
         { label: 'Last 30 Days', value: 'last 30 days' },
         { label: 'All Time', value: '' }
     ];
 
-    let selected = $derived(items.find((item) => item.value === value) || items[items.length - 1]);
+    let selected = $derived((items.find((item) => item.value === value) || items[items.length - 1]) as Item);
 </script>
 
 <Select.Root type="single" {items} bind:value>

src/Exceptionless.Web/ClientApp/src/lib/features/shared/components/filters/filters.svelte.ts

@@ -612,7 +612,7 @@ export function processFilterRules(filters: IFilter[], changed?: IFilter): IFilt
     const filtered: IFilter[] = [];
     Object.entries(groupedFilters).forEach(([, items]) => {
         if (items && items.length > 0) {
-            filtered.push(items[0]);
+            filtered.push(items[0] as IFilter);
         }
     });
 

src/Exceptionless.Web/ClientApp/src/lib/features/users/api.svelte.ts

@@ -50,7 +50,7 @@ export function mutateEmailAddress(props: UpdateEmailAddressProps) {
         },
         mutationKey: queryKeys.idEmailAddress(props.id),
         onSuccess: (data, variables) => {
-            const partialUserData: User = { email_address: variables.email_address, is_email_address_verified: data.is_verified };
+            const partialUserData: Partial<User> = { email_address: variables.email_address, is_email_address_verified: data.is_verified };
 
             const user = queryClient.getQueryData<User>(queryKeys.id(props.id));
             if (user) {

src/Exceptionless.Web/ClientApp/src/routes/(app)/account/manage/+page.svelte

@@ -31,7 +31,7 @@
         }
     });
 
-    const updateEmailAddressForm = superForm(defaults(userResponse.data ?? {}, classvalidatorClient(User)), {
+    const updateEmailAddressForm = superForm(defaults(userResponse.data ?? new User(), classvalidatorClient(User)), {
         dataType: 'json',
         id: 'update-email-address',
         async onUpdate({ form, result }) {
@@ -58,7 +58,7 @@
         validators: classvalidatorClient(User)
     });
 
-    const updateUserForm = superForm(defaults(userResponse.data ?? {}, classvalidatorClient(UpdateUser)), {
+    const updateUserForm = superForm(defaults(userResponse.data ?? new UpdateUser(), classvalidatorClient(UpdateUser)), {
         dataType: 'json',
         id: 'update-user',
         async onUpdate({ form, result }) {

src/Exceptionless.Web/ClientApp/tsconfig.json

@@ -7,11 +7,14 @@
         "experimentalDecorators": true,
         "emitDecoratorMetadata": true,
         "forceConsistentCasingInFileNames": true,
+        "moduleDetection": "force",
+        "moduleResolution": "bundler",
+        "noImplicitOverride": true,
+        "noUncheckedIndexedAccess": true,
         "resolveJsonModule": true,
         "skipLibCheck": true,
         "sourceMap": true,
-        "strict": true,
-        "moduleResolution": "bundler"
+        "strict": true
     }
     // Path aliases are handled by https://kit.svelte.dev/docs/configuration#alias
     // except $lib which is handled by https://kit.svelte.dev/docs/configuration#files

src/Exceptionless.Web/ClientApp/vite.config.ts

@@ -87,7 +87,7 @@ function getAspNetConfig() {
     if (aspnetHttpsPort) {
         url = `https://localhost:${aspnetHttpsPort}`;
     } else if (aspnetUrls) {
-        url = aspnetUrls.split(';')[0];
+        url = aspnetUrls.split(';')[0] as string;
     }
 
     const wsUrl = url.replace('https://', 'wss://').replace('http://', 'ws://');