Fixed an issue with serializer not respecting JSON property attributes and auto validation

Author: niemyjski

src/Exceptionless.Web/Models/Auth/ExternalAuthInfo.cs

@@ -1,22 +1,21 @@
 using System.ComponentModel.DataAnnotations;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Serialization;
 
 namespace Exceptionless.Web.Models;
 
+// NOTE: This will bypass our LowerCaseUnderscorePropertyNamesContractResolver and provide the correct casing.
+[JsonObject(NamingStrategyType = typeof(CamelCaseNamingStrategy))]
 public record ExternalAuthInfo
 {
     [Required]
-    [JsonProperty("clientId")]
     public required string ClientId { get; init; }
 
     [Required]
-    [JsonProperty("code")]
     public required string Code { get; init; }
 
     [Required]
-    [JsonProperty("redirectUri")]
     public required string RedirectUri { get; init; }
 
-    [JsonProperty("inviteToken")]
     public string? InviteToken { get; init; }
 }

src/Exceptionless.Web/Startup.cs

@@ -10,7 +10,6 @@
 using Exceptionless.Web.Security;
 using Exceptionless.Web.Utility;
 using Exceptionless.Web.Utility.Handlers;
-using Exceptionless.Web.Utility.Results;
 using FluentValidation;
 using Foundatio.Extensions.Hosting.Startup;
 using Foundatio.Repositories.Exceptions;
@@ -196,6 +195,7 @@ private void CustomizeProblemDetails(ProblemDetailsContext ctx)
         if (ctx.ProblemDetails is ValidationProblemDetails validationProblem)
         {
             // This might be possible to accomplish via serializer.
+            // NOTE: the key could be wrong for things like ExternalAuthInfo where the keys are camel case.
             validationProblem.Errors = validationProblem.Errors
                 .ToDictionary(
                     error => error.Key.ToLowerUnderscoredWords(),
@@ -204,7 +204,6 @@ private void CustomizeProblemDetails(ProblemDetailsContext ctx)
         }
 
         // errors
-
         // TODO: Check casing of property names of model state validation errors.
     }
 

src/Exceptionless.Web/Utility/AutoValidationActionFilter.cs

@@ -43,11 +43,12 @@ public async Task OnActionExecutionAsync(ActionExecutingContext context, ActionE
                 foreach (var error in errors)
                 {
                     // TODO: Verify nested object keys
-                    var modelStateEntry = context.ModelState[error.Key];
+                    // NOTE: Fallback to finding model state errors where the serializer already changed the key, but differs from ModelState like ExternalAuthInfo (without NamingStrategyType) 
+                    var modelStateEntry = context.ModelState[error.Key] ?? context.ModelState[error.Key.ToLowerUnderscoredWords()];
                     foreach (string errorMessage in error.Value)
                     {
                         hasErrors = true;
-                        if (modelStateEntry is null || !modelStateEntry.Errors.Contains(e => String.Equals(e.ErrorMessage, errorMessage)))
+                        if (modelStateEntry is null || !modelStateEntry.Errors.Contains(e => String.Equals(e.ErrorMessage, errorMessage, StringComparison.OrdinalIgnoreCase)))
                             context.ModelState.AddModelError(error.Key, errorMessage);
                     }
                 }

tests/http/auth.http

@@ -18,7 +18,7 @@ Content-Type: application/json
 {
   "email": "{{email}}",
   "password": "{{password}}",
-  "name":"test"
+  "name": "test"
 }
 
 ### Signup with token
@@ -28,5 +28,15 @@ Content-Type: application/json
 {
   "email": "{{email}}",
   "password": "{{password}}",
-  "name":"test"
+  "name": "test"
+}
+
+### OAuth Login
+POST {{apiUrl}}/auth/google
+Content-Type: application/json
+
+{
+    "code": "code",
+    "clientId": "clientId",
+    "redirectUri": "http://localhost",
 }