Skip to content

Commit 61abb71

Browse files
authored
Svelte 5.0 support (#1716)
* Upgraded deps * Fixed svelte 5 compiler errors * fixed import * run npm build * Updated svelte * Update deps * ensure node is setup before caching. * set npm cache path * Add conditional step
1 parent 688736d commit 61abb71

File tree

22 files changed

+441
-233
lines changed

22 files changed

+441
-233
lines changed

.github/workflows/build.yaml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ jobs:
118118
timeout-minutes: 30
119119
defaults:
120120
run:
121-
working-directory: ./src/Exceptionless.Web/ClientApp
121+
working-directory: src/Exceptionless.Web/ClientApp
122122

123123
steps:
124124

@@ -127,23 +127,28 @@ jobs:
127127
with:
128128
fetch-depth: 0
129129

130-
- name: Cache node_modules
131-
uses: actions/cache@v4
132-
with:
133-
path: node_modules
134-
key: node-modules-${{ hashFiles('package-lock.json') }}
135-
136130
- name: Setup Node.js environment
137131
uses: actions/setup-node@v4
138132
with:
139133
node-version: 20
140134

135+
- name: Cache node_modules
136+
uses: actions/cache@v4
137+
id: cache-node-modules
138+
with:
139+
path: src/Exceptionless.Web/ClientApp/node_modules
140+
key: node-modules-${{ hashFiles('package-lock.json') }}
141+
141142
- name: Install Npm Packages
143+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
142144
run: npm ci --force
143145

144146
- name: Lint Client
145147
run: npm run lint
146148

149+
- name: Build
150+
run: npm run build
151+
147152
- name: Run Unit Tests
148153
run: echo "npm run test:unit"
149154

src/Exceptionless.Core/Exceptionless.Core.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.0-rc.2.24473.5" />
3131
<PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="9.0.0-rc.2.24474.3" />
3232
<PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.0-rc.2.24473.5" />
33-
<PackageReference Include="Stripe.net" Version="46.2.0" />
33+
<PackageReference Include="Stripe.net" Version="46.2.1" />
3434
<PackageReference Include="System.DirectoryServices" Version="9.0.0-rc.2.24473.5" />
3535
<PackageReference Include="UAParser" Version="3.1.47" />
3636
<PackageReference Include="Foundatio.Repositories.Elasticsearch" Version="7.17.12" Condition="'$(ReferenceFoundatioRepositoriesSource)' == '' OR '$(ReferenceFoundatioRepositoriesSource)' == 'false'" />

src/Exceptionless.Web/ClientApp/eslint.config.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
import js from '@eslint/js';
1+
import eslint from '@eslint/js';
22
import prettier from 'eslint-config-prettier';
33
import perfectionist from 'eslint-plugin-perfectionist';
44
import svelte from 'eslint-plugin-svelte';
55
import globals from 'globals';
6-
import ts from 'typescript-eslint';
6+
import tseslint from 'typescript-eslint';
77

88
/** @type {import('eslint').Linter.FlatConfig[]} */
9-
export default [
10-
js.configs.recommended,
11-
...ts.configs.recommended,
9+
export default tseslint.config(
10+
eslint.configs.recommended,
11+
...tseslint.configs.recommended,
1212
...svelte.configs['flat/recommended'],
1313
perfectionist.configs['recommended-natural'],
1414
prettier,
@@ -25,7 +25,7 @@ export default [
2525
files: ['**/*.svelte'],
2626
languageOptions: {
2727
parserOptions: {
28-
parser: ts.parser
28+
parser: tseslint.parser
2929
}
3030
}
3131
},
@@ -38,4 +38,4 @@ export default [
3838
'perfectionist/sort-svelte-attributes': 'off'
3939
}
4040
}
41-
];
41+
);

0 commit comments

Comments
 (0)