Naming convention for boolean props/hooks #61
Closed
harrywebdev
started this conversation in
General
Replies: 2 comments
-
It's probably better, but it's temporal code I will deprecate once React |
Beta Was this translation helpful? Give feedback.
0 replies
-
This API does not exist anymore. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I understand this is a pretty subjective matter. Anyway, I came across this hook
evolu/packages/evolu/src/db.ts
Lines 89 to 94 in 15fa758
and I thought it would be nicer if the state is inverted (e.g.
areLoaded
->areLoading
). The other suggestion would be to prefix boolean withis
to imply the type from a quick glance.Btw. I did not try this code, just rewrote it based on an assumption.
Beta Was this translation helpful? Give feedback.
All reactions