splitSignatures v6

[moneyDev1111]

hey @ricmoo and @everyone:)
I have a problem with getting signature verified. It works with ethers v5, but doesn't with v6...
here's the code
solidity

function transfer(
        address to,
        uint256 amount,
        Signature[2] memory signatures
    ) external {
        // Authenticity check
        require(
            _verifySignature(to, amount, signatures[0]) == signatories[0],
            "Access restricted"
        );
        require(
            _verifySignature(to, amount, signatures[1]) == signatories[1],
            "Access restricted"
        );

        payable(to).sendValue(amount);
    }
    

    function _verifySignature(
        address to,
        uint256 amount,
        Signature memory signature
    ) internal pure returns (address signer) {
        // 52 = message byte length
        string memory header = "\x19Ethereum Signed Message:\n52";

        bytes32 messageHash = keccak256(abi.encodePacked(header, to, amount));

        // Perform the elliptic curve recover operation
        return ecrecover(messageHash, signature.v, signature.r, signature.s);
    }

hardhat

// Prepare withdraw Message
const message = solidityPacked(['address', 'uint256'], [my.address, MY_WITHDRAW]);
const messageBuffer = concat([message]);

// Sign message
let signatory1Signature = await deployer.signMessage(messageBuffer);
let signatory2Signature = await signer2.signMessage(messageBuffer);

// Split signatures (v,r,s)
let signatory1SplitSig = Signature.from(signatory1Signature);
let signatory2SplitSig = Signature.from(signatory2Signature);

// Call transfer with signatures
await multiSigWallet.transfer(my.address, MY_WITHDRAW, [signatory1SplitSig, signatory2SplitSig]);

I get Access restricted using ethers v6 Signature.from(), but the utils.splitSignature() from the v5 works... How to fix it? Please help. Thank you:)

[ricmoo]

Can you provide the error you are receiving?

[moneyDev1111]

ok, I'll try frist from the hardhat side))
the output from the v5 splitSingature and v6 Signature.from are different in a lot of ways....:((((

this is v5

{
  r: '0x02efb15972bac0ba578c0f95623bd95d10ca5f601d1d999308187e7dae738733',
  s: '0x213c76c501b9d9d5d4e81215ba15f1feb6e78be070dbca257f2b61d163e84255',
  _vs: '0xa13c76c501b9d9d5d4e81215ba15f1feb6e78be070dbca257f2b61d163e84255',
  recoveryParam: 1,
  v: 28,
  yParityAndS: '0xa13c76c501b9d9d5d4e81215ba15f1feb6e78be070dbca257f2b61d163e84255',
  compact: '0x02efb15972bac0ba578c0f95623bd95d10ca5f601d1d999308187e7dae738733a13c76c501b9d9d5d4e81215ba15f1feb6e78be070dbca257f2b61d163e84255'
}

and this is v6
Signature { r: "0xd3bca2a5a0fbdc6b067c099319eaff68c4cce1bc2a66a05f5c9d4ff090861ab7", s: "0x1b1072736c76c5b7617deb36e91d2053451c35ff5f138711778269f0f0d64d5a", yParity: 0, networkV: null }

[moneyDev1111]

@ricmoo ooooooooooooooooooooooooooooooooooooooo please help:))))

[moneyDev1111]

I've took the splitSignature from the v5 separately and used it in the v6 project, it works, and the output now looks the same by its keys, but the values are different..... and again I get access restricted revert...

[moneyDev1111]

uitls.concat gives the Uint8Array(52), and v6 concat gives the same output as the solidityPacked, I mean it doesn't change anything in this lines

const message = solidityPacked(['address', 'uint256'], [attacker.address, ATTACKER_WITHDRAW]);
const messageBuffer = concat([message]);
// message and messageBuffer are identical.. maybe that's why it happens, is there a way to convert it to the uint8Array(52)?

yes it's the issue... so... is this a ethers bug? or a wrong function in my solidit contract maybe?
here's the code

[moneyDev1111]

it works like this
I pasted the concat function from the ethers v5

	before(async function () {
		/** SETUP EXERCISE - DON'T CHANGE ANYTHING HERE */
		function addSlice(array: Uint8Array): Uint8Array {
			if (array.slice) {
				return array;
			}

			array.slice = function () {
				const args = Array.prototype.slice.call(arguments);
				return addSlice(new Uint8Array(Array.prototype.slice.apply(array, args)));
			};

			return array;
		}

		function concat2(items: ReadonlyArray<BytesLike>): Uint8Array {
			const objects = items.map((item) => arrayify(item));
			const length = objects.reduce((accum, item) => accum + item.length, 0);

			const result = new Uint8Array(length);

			objects.reduce((offset, object) => {
				result.set(object, offset);
				return offset + object.length;
			}, 0);

			return addSlice(result);
		}

		[deployer, signer2, attacker] = await getSigners();

		// Deploy multi sig
		multiSigWallet = await deployContract('MultiSignatureWallet', [[deployer.address, signer2.address]]);

		// Send ETH to multisig Wallet
		await deployer.sendTransaction({
			to: multiSigWallet.target,
			value: ETH_IN_MULTISIG,
		});

		// Prepare withdraw Message
		const message = solidityPacked(['address', 'uint256'], [attacker.address, ATTACKER_WITHDRAW]);
		
		const messageBuffer = concat2([message]);

		// Sign message
		let signatory1Signature = await deployer.signMessage(messageBuffer);
		let signatory2Signature = await signer2.signMessage(messageBuffer);

		// Split signatures (v,r,s)
		let signatory1SplitSig = Signature.from(signatory1Signature);
		let signatory2SplitSig = Signature.from(signatory2Signature);

		// Call transfer with signatures
		await multiSigWallet.transfer(attacker.address, ATTACKER_WITHDRAW, [signatory1SplitSig, signatory2SplitSig]);

and if to use concat function from the ethers v6 it just gives the same output as the message itself
so these 2 lines will give the same output...

const message = solidityPacked(['address', 'uint256'], [attacker.address, ATTACKER_WITHDRAW]);
const messageBuffer = concat([message]);

and that's where the problem is

[moneyDev1111]

and here's the piece of the solidity code

function transfer(
        address to,
        uint256 amount,
        Signature[2] memory signatures
    ) external {
        // Authenticity check
        require(
            _verifySignature(to, amount, signatures[0]) == signatories[0],
            "Access restricted"
        );
        require(
            _verifySignature(to, amount, signatures[1]) == signatories[1],
            "Access restricted"
        );

        payable(to).sendValue(amount);
    }

    function _verifySignature(
        address to,
        uint256 amount,
        Signature memory signature
    ) internal pure returns (address signer) {
        // 52 = message byte length
        string memory header = "\x19Ethereum Signed Message:\n52";

        bytes32 messageHash = keccak256(abi.encodePacked(header, to, amount));

        // Perform the elliptic curve recover operation
        return ecrecover(messageHash, signature.v, signature.r, signature.s);
    }

[moneyDev1111]

@ricmoo so is it a bug? or... how to properly get it fixed? cause.. it's not suppose to be for someone to use a concat from v5 in v6 to multisig right...