send all native tokens from a wallet, EIP-1559

[moneyDev1111]

Hi, I think I'm doing everything (at least almost) correctly but still I get an error "insufficient funds for gas * price + value:"

I want to send all ETH a wallet has to another wallet. So I guess I should just subtract the fees from the value right?

const txExample = {
			to: acc.okxAddress,
			value: parseUnits(theAmount.toFixed(theToken.unit === 'mwei' ? 6 : 18), theToken.unit),
		};

const estimateGas =  await signer.estimateGas(txExample);
console.log('ESTIMATE GAS', estimateGas!);

const subtractForGas = +estimateGas!.toString() * +formatEther(gasPrice!).toString();

const allAssets = theAmount - subtractForGas : 0;
console.log('Sending the tokens...');

if (Math.sign(allAssets) === -1) {
  throw new Error('Not enough Native token to pay for gas');
}

const sendTokensTx = 
    await signer.sendTransaction({
      to: acc.okxAddress,
      value: parseUnits(allAssets.toFixed(theToken.unit === 'mwei' ? 6 : 18), theToken.unit),
    })

const tx = await sendTokensTx.wait();

theAmount is in ether so I think everything is ok and also in ether

example

theAmount 0.001387691715564448
subTractForGas 0.0000021000000000000002
allAssets 0.0013855917155644478

but the example is from the time I multiplied gasPrice by 21000 and got the error so I thought I should estimate the gas myself, but it didn't fix the issue tho the number was much higher ~400000

UPD it works if I add gaslimit: estimateGas and gasPrice params to the tx... but this is not how it suppose to be for the EIP 1559 transactions right?

also why is estimateGas is not equal to 21000 ?....

I've googled that for the EIP 1559 tx I need to add and put the same values for maxFeePerGas and maxPriorityFeePerGas. but first of all it doesn't work, and the second is ehmm... well you've told that the ethers js sets the maxPriorityFeePerGas always to 1 gwei and it seems to be enough for everything? so obviously if to set the maxFeePerGas to 1 gwei, no tx will be sent, and then for example if the gasPrice is 50 gwei why does anybody need to increase the maxPriorityFeePerGas to 50 gwei just for sending the same values in both params? Sounds weird and doesn't work for me in the first place... Could you please explain how to do it correctly? Sending all native token balance from one wallet to another one? Thank you:)

[ricmoo]

Heya!

So, clearing out an EOA account without leaving any dust is not really possible outside some incredible luck in Ethereum with EIP-1559, but I’ll go into a little more detail.

First of all though, the fact you are using .toFixed means you are using a JavaScript number, which can already cause problems as there is likely internal rounding in the IEEE 754 number. That rounding could be down (in which case there will be dust regardless) or up (in which case you will get insufficient funds). The way floating point numbers work is complex, so predicting which requires a lot more numeric analysis and the easiest solution is to use BigInt so your values and maths remain accurate and unrounded.

If the gas limit isn’t 21000, I’m guessing that either the too dress is a contract, that an access list is specified, data is included in the transaction, or something along those lines. There are lots of reasons Ethereum charges extra fees, but it should be 21000 for transferring from an EOA to another EOA.

The reason draining an account is difficult in EIP-1559 is that the baseFee used is protocol-defined and moves up and down in every block. And if you provide a maxFeePerGas equal to the current baseFee, and the next block goes up (50% chance) then your tx will have insufficient funds. If it goes down, dust. The general rule-of-thumb is to use 2x the current blocks baseFee, but the next block can only increase by a maximum of 12.5%. But in the even of contention for block space, you might have to wait more than one block, so even if you provide 12.5% extra, after two blocks, each block could have raised it 12.5% (for a total of 26.5%), so now your fee becomes insufficient again.

Basically, a dust free transfer is near impossible without knowing the future.

Does that make sense?

[moneyDev1111]

@ricmoo well I don't see any other option, I can't use bigints because I need to multiply the amount by a float number at some point of time in any case... or do I.....
.... I will check the rest a bit later. Thanks a lot!

[ricmoo]

You can usually replace any float with its rational equivalent, with the numerator having higher precedence in the maths. For example 1.2 * x becomes (12n * x) / 10n. If you need the ceiling, ((12n * x ) + 9n) / 10n. It just requires a little numeric analysis. But your life will be much better for it. :)

[moneyDev1111]

@ricmoo alright, slowly I'm getting there, changed almost everything to BigInts but... there's a Math.random() method that is a float number, so i should do the same with it? define its length( because it can be different) and just apply your "formula"? or is there some simpler way? thank you....)

Yeah, I think it does work if to treat Math.random() as any other float number

[moneyDev1111]

~~// that how it was without bigints
console.log((Math.random() * (max - soCalledMin) + soCalledMin).toString(), theToken.unit);

// this is how it is with bigint that unfortunately gives 0.0 as the result
console.log(formatUnits(((randomMultiplier * (max - soCalledMin) + soCalledMin) / randomDivider).toString(), theToken.unit));
// here's the same but with the actual digits
console.log(formatUnits((36440686469045440n * (5242365894885543n - 5242365894885543n) + 5242365894885543n) / 100000000000000000n, theToken.unit));
// so in short this is the example where no randomization is done, I mean is that the result should be the same as the wallet balance,
// which is 0.005242365894885543 in ether
// but the last line here 5242365894885543n) / 100000000000000000n, should move the decimal point of 5242365894885543n // "backwards" for it to become the 0.005242365894885543, but I guess it's impossible with bigint? so.... I don't see how I can
// use math.random with bigint....((((((
console.log(formatUnits((36440686469045440n * (5242365894885543n - 5242365894885543n) + 5242365894885543n) / 100000000000000000n, theToken.unit)); // the result is 0.0 instead of 0.005242365894885543((~~

[moneyDev1111]

I mean that if the random number is less than 1, then it seems to impossible to get the needed bigint, because it will always return 0 (((