Incorrect getTransactionReceipt return type

[bvanderdrift]

Ethers Version

5.7.2

Search Terms

getTransactionReceipt types

Describe the Problem

The current @ethersproject/abstract-provider has

abstract getTransactionReceipt(transactionHash: string): Promise<TransactionReceipt>;

Where the return type should be Promise<TransactionReceipt | null> as per the JSON-RPC definitions. This does seem to be correct in ethers.js repo.

@ethersproject/abstract-provider should be updated accordingly.

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

node.js (v12 or newer)

Environment (Other)

No response

[ricmoo]

In v5, the tsconfig does not include the strictNullCheck, so null is always implied. This also cannot be changed in v5 as it requires a major version change.

That said, strictNullCheck is enabled in v6, which includes explicit null in return types. :)