Extraneous comments in the code #3387
flanagansteve
started this conversation in
General
Replies: 1 comment
-
I think It is something I was planning to add in. When no address was provided, a Geth node used to use the current account, if one was configured, otherwise 0. But then they changed the default behaviour to always use 0. And specifying 0 did something else (I forget what). So, I think I commented it out in case it needed to go back in? I would have to look at the changelog from then though. It is a good idea for me to re-examine this behaviour and figure out the correct thing to do in v6. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Suggestion
I was inspecting the
packages/contracts/src.ts/index.ts
and noticed a commented-outelse
case: hereGrep-ing the codebase, i found 7 other similar instances of commented-out
else
sWould we like to remove these? if so, i can make a quick PR this evening
Beta Was this translation helpful? Give feedback.
All reactions