Conflict With Hardhat Provider Request

[Zer0dot]

Hey folks!

First off, I think ethers is one of the greatest public services ever made in the web3 space, I've got huge respect for you @ricmoo !

I've run into what appears to be a minor inconsistency in how ethers formats the storage slot parameter in the provider.getStorageAt() function. This calls hexValue() on the slot parameter, which, as seen below, trims down leading zeros:

export function hexValue(value: BytesLike | Hexable | number | bigint): string {
    const trimmed = hexStripZeros(hexlify(value, { hexPad: "left" }));
    if (trimmed === "0x") { return "0x0"; }
    return trimmed;
}

This causes a problem when used in conjunction with the Hardhat provider because it validates that the slot parameter is exactly 66 characters long, so the abi encoded slot as a string.

I'm not sure this is really a bug, as it doesn't break anything (it can be circumvented by directly sending the request to the Hardhat provider) but I thought I'd start a discussion about it.

[Zer0dot]

Just updated to ethers 5.7.1, the issue doesn't exist there. In hindsight, probably should have done that earlier..

[ricmoo]

FYI, fixed with #2982. :)