Incorrect From Address When Parsing Signed Transaction

[jettblu]

Hello! While running tests on transaction signatures, I came across the following error. The parsed transaction returns a 'from' field that does not match the address corresponding to the signing key. However, the parsed transaction still succeeds when I test the recovered address against the original. This is an issue as the incorrect from field results in transactions failing due to 'insufficient funds'. Do you have any idea as to why the address on the populated transaction differs from the address that represents the signing key? I have also tried with the standard wallet implementation, but the issue persists.

Signature code

Test

Recap
As mentioned above, the recovered address matches the original address, but the transaction's from field is populated with an incorrect address.

Thanks in advance for taking a look (:
Jett

[ricmoo]

My first guess is that the type is missing? Which will change how it is serialized…

[ricmoo]

It's too hard to debug without a concrete example though. Do you have an example with a private key you can share (some throw away key), along with all the properties passed in, what you expected and what came out? The above example has a massive nonce, and every part of the tx must match, so I need the fee data (e.g. maxFeePerGas, etc. if using EIP-1559, or gasPrice if using a legacy tx), actual nonce, etc.

[jettblu]

Sure, sorry for the initial lack of clarity. Here is a link to code and comments that should help. Note: the serialized 'v' field differs from the original signature's 'v' field.

[jettblu]

After logging the parsed transaction produced by the Ethers Wallet package, I noticed the r,s, and v signature fields all differ from those produced by my implementation. As the high level signing code is the same (resolve properties -> serialize -> hash -> sign digest) are the same, I am unsure why the signatures differ.

[ricmoo]

Are you using RFC-6979 in your ECC signing library?

[jettblu]

Yep. I found the bug. Turned out to be quite simple and my fault. I was hashing the buffer of the transaction. This resulted in incorrect signatures. I removed the buffer and everything works great.

While this issue cost a lost of time, I became much more familiar with your library and the general Ethereum signing process.
Thanks for your help!