Problem with using ethers.js source in other project

[Idan-Shperling]

Hi guys!,

let's say we change the ethers.js wallet package like this:

I'm adding a little my_foo() method like in the picture and run: npm i && npm run auto-build

I have a project dir like that:
/project_dir/ethers.js
/project_dir/my_project

then I run npm pack ethers in the ethers.js dir and everything is packed nicely to a zipped file. then I go to the other my_project dir and run npm install ../ethers.js/zip_file
when I check the node_modules dir under my_project/node_modules/@etherproject/wallet I cant find my_foo() method.

so basically if I have a local package how can I change that package and see the changes in another project?

[zemse]

If you have made changes to @etherproject/wallet then that package needs to be published first. Since that needs npm keys for @ethersproject, you would have to publish it on your name i.e. @idan-krayon/ethers-wallet. Then the dependency needs to be updated in ethers package, basically remove @etherproject/wallet and add your package, might also involve changes in src. ccing @ricmoo to make sure if this makes sense.

I totally get this is complicated, I myself have been in that boat. I'd suggest you another route which I settle in, if all you want is to tweak how ethers work. Ethers is cool, particularly in this context where most functionality can be easily overridden. And this can enable application specific changes possible without maintaining ethers fork, i.e. lets say ethers fixes a bug or new feature added, no headache to update fork, just install latest ethers in your project.

// create this module in your project
export class WalletCustom extends Wallet {
  // lets say you wanna add another method
  myFoo() {
    // logic
  }

  async signTransaction(tx) {
    // add any logic you'd want to
    const result = await super.signTransaction(tx);
    console.log('sign result', result);
    return result;
  } 
}

// in other files
import { WalletCustom } from '../utils/ethers-extended';
const wallet = new WalletCustom('...')
wallet.myFoo() // works!
await contract.connect(wallet).transfer('0xFriend', 1234); // this will use the overriden signTransaction method

[Idan-Shperling]

Thanks for the answer.

In the first place, I used your second route by extending the Wallet functionality, but then I had to make some changes in other packages like in SigningKey class, and then stuff got very messy for me.

So I've got the ethers.js in other project directory and made all my calls to that directory like this:
import { Wallet } from '../../ethers/packages/wallet';

but i have difficulties to build everything because in the dist folder the relative path changes and i need to manually change all paths to the ethers folder manually to :import { Wallet } from '../../../ethers/packages/wallet';

the first suggestion sounds like a good plan but I don't really want it to be published publicly. can I publish it privately?

[Idan-Shperling]

well, I've managed to solve it with a little trick, i don't really like it, but it works.
i ran npm link ../../ethers/node_modules/ethers/ in my project_dir/node_modules dir
everything works like a charm.