Is there a difference between web3.py sign transaction vs ethers.js sign transaction ?

[georgepadayatti]

ethers.js signTransaction() function definition is given below:

ethers.js/packages/wallet/lib/index.js

Lines 154 to 166 in a71f518

	Wallet.prototype.signTransaction = function (transaction) {
	var _this = this;
	return (0, properties_1.resolveProperties)(transaction).then(function (tx) {
	if (tx.from != null) {
	if ((0, address_1.getAddress)(tx.from) !== _this.address) {
	logger.throwArgumentError("transaction from address mismatch", "transaction.from", transaction.from);
	}
	delete tx.from;
	}
	var signature = _this._signingKey().signDigest((0, keccak256_1.keccak256)((0, transactions_1.serialize)(tx)));
	return (0, transactions_1.serialize)(tx, signature);
	});
	};

eth-account sign_transaction() function definition is give below:

https://github.com/ethereum/eth-account/blob/7f5eefccaf4617e645895106bf396e728f81f64e/eth_account/account.py#L670-L807

In sign_transaction() (eth-account packaged used in web3.py), they expect the unsigned transaction to contain "gas" field, but in signTransaction() (ethers.js), it appears there is no transaction field validation at all.

Is this a bug or am I missing something ?

[ricmoo]

It is perfectly valid to have a gas of 0 (which is what is used if nothing is provided), since this can be used for various protocols which use a signed transaction but want to intentionally prevent node relay if broadcast.

I also recommend reading the TypeScript source code, rather than the generated code; it’s much more pleasant to look at. :)

Does that make sense?

[ricmoo]

(also note, all property validation is done in serialize)

[georgepadayatti]

Thanks for the links. Will read through the same.

[georgepadayatti]

@ricmoo I noticed the following differences in allowed keys in a transaction while browsing through the source code.

In ether.js following are the allowed fields,

ethers.js/packages/transactions/src.ts/index.ts

Lines 105 to 107 in a71f518

	const allowedTransactionKeys: { [ key: string ]: boolean } = {
	chainId: true, data: true, gasLimit: true, gasPrice:true, nonce: true, to: true, type: true, value: true
	}

In eth-account (web3.py), the following are the allowed fields,

https://github.com/ethereum/eth-account/blob/7f5eefccaf4617e645895106bf396e728f81f64e/eth_account/_utils/legacy_transactions.py#L80-L88

ALLOWED_TRANSACTION_KEYS = {
    'nonce',
    'gasPrice',
    'gas',
    'to',
    'value',
    'data',
    'chainId',  # set chainId to None if you want a transaction that can be replayed across networks
}

In ethers.js, the allowed fields include gasLimit field while in eth-account (web3.py), allowed fields include, gas.

Could you help understand this ?

[georgepadayatti]

I have resolved this issue, as gasLimit in ethers.js is same as gas in eth-account (web3.py).

@ricmoo Thanks for the help.