BIP39 passphrase support #2718
Unanswered
beemeeupnow
asked this question in
Q&A
Replies: 1 comment
-
Reading BIP39 it makes sense to add to Mnemonic because it is used in combination with the phrase. As I need this feature I opened PR #2721 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
HDNode.fromMnemonic accepts such a password, but it does not get stored and Wallet just passes
null
when checking mnemonic/address matching.Ref:
ethers.js/packages/wallet/src.ts/index.ts
Line 64 in 7b134bd
This causes problems if I use HDNode.fromMnemonic and pass a password, then later use .derivePath() and pass that HDNode to create a new Wallet (result is failing the check right after the above line)
It seems trivial to fix, but I wanted to check what would be recommended. (happy to send a PR)
e.g. could add the passphrase to HDnode directly and store it so it can be retrieved later and passed during the above call in the code ref, or could add it to the Mnemonic interface and retrieve it from that
Beta Was this translation helpful? Give feedback.
All reactions