BigNumber.mulTruncate kind of operation

[marcelomorgado]

Do you think that would make sense having these kind of BN operators? I mean, I have this kind of code a lot in my test cases, for instance:
amount.mul(fee).div(parseEther('1')) that could be written amount.mulTruncate(fee) we could have an interface like this mulTruncate(amount: BigNumber, divisorDecimals: BigNumber | number = 18)

WDYT?

[ricmoo]

You can add this to the prototype yourself, to access it, à la BigNumber.prototype.mulTrunc = function(val) { return this.mul(val).div(One); }.

The goal of the ethers BigNumber is to be intentionally minimal though, since in the future it will be going away (in v7, ES2020 BigInt will have fairly wide support), so I don’t think it makes a lot of sense to add.

Make sense?

[marcelomorgado]

Yes, it does. Thanks!