Replies: 1 comment
-
This is already in v6, which will be available as a beta soon. :) It isn’t a change that will be made in v5 though, as it required substantial code changes, updates to method signatures and new types, which aren’t backwards compatible. Also, quick note: Signer doesn’t have an |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Having to add
signer.address
when calling a contract function with an address argument makes the code more verbose. I'm particularly interested in the effect of this verbosity on tests, which become harder to read.As far as I can tell, it would be possible for Ethers.js to accept signers where addresses are expected. If this is not feasible for all kinds of signers, it is probably feasible for some, and I think it should be considered for that subset at least.
Beta Was this translation helpful? Give feedback.
All reactions