calling contract method with many return values gives overflow (fault="overflow", operation="toNumber", value="<LARGE_NUMBER>", code=NUMERIC_FAULT, version=bignumber/5.5.0)

[michaeljohnbennett]

I have a somewhat similar issue to other discussions but it appears to be a problem when I have a public view function returning a few arrays.

I'm using typechain on top of ethers.js and I have this solidity function i call:

/**
     * @dev Code to get the probabilities easily from the config.
     */
    function getGenerationCardTypeSettings(uint8 _gen, CardType _cardType)
        public
        view
        returns (
            uint8 gen,
            CardType cardType,
            bool exists,
            uint256 maxQtyPerOpen,
            uint16[] memory cardProbabilities,
            uint256[] memory nftIds,
            CardNFT.CardRarity[] memory rarities,
            uint8[] memory cardValues
        )
    {
        gen = _gen;
        cardType = _cardType;
        exists = generationCardProbabilityMap[_gen][_cardType].exists;
        maxQtyPerOpen = generationCardProbabilityMap[_gen][_cardType].maxQtyPerOpen;
        cardProbabilities = generationCardProbabilityMap[_gen][_cardType].cardProbabilities;
        nftIds = generationCardProbabilityMap[_gen][_cardType].nftIds;
        rarities = generationCardProbabilityMap[_gen][_cardType].rarities;
        cardValues = generationCardProbabilityMap[_gen][_cardType].values;
    }

and the ABI is:

{
    "inputs": [
      {
        "internalType": "uint8",
        "name": "_gen",
        "type": "uint8"
      },
      {
        "internalType": "enum DappStore.CardType",
        "name": "_cardType",
        "type": "uint8"
      }
    ],
    "name": "getGenerationCardTypeSettings",
    "outputs": [
      {
        "internalType": "uint8",
        "name": "gen",
        "type": "uint8"
      },
      {
        "internalType": "enum DappStore.CardType",
        "name": "cardType",
        "type": "uint8"
      },
      {
        "internalType": "bool",
        "name": "exists",
        "type": "bool"
      },
      {
        "internalType": "uint256",
        "name": "maxQtyPerOpen",
        "type": "uint256"
      },
      {
        "internalType": "uint16[]",
        "name": "cardProbabilities",
        "type": "uint16[]"
      },
      {
        "internalType": "uint256[]",
        "name": "nftIds",
        "type": "uint256[]"
      },
      {
        "internalType": "enum CardNFT.CardRarity[]",
        "name": "rarities",
        "type": "uint8[]"
      },
      {
        "internalType": "uint8[]",
        "name": "cardValues",
        "type": "uint8[]"
      }
    ],
    "stateMutability": "view",
    "type": "function"
  },

Which give me a typechain definition of:

getGenerationCardTypeSettings(
    _gen: BigNumberish,
    _cardType: BigNumberish,
    overrides?: CallOverrides
  ): Promise<
    [
      number,
      number,
      boolean,
      BigNumber,
      number[],
      BigNumber[],
      number[],
      number[]
    ] & {
      gen: number;
      cardType: number;
      exists: boolean;
      maxQtyPerOpen: BigNumber;
      cardProbabilities: number[];
      nftIds: BigNumber[];
      rarities: number[];
      cardValues: number[];
    }
  >;

When I make a call on the hardhat console for instance it all returns fine.

When I use it on a react frontend, talking to my localhost hardhat node via metamask I get this error:

cardProbabilities: overflow (fault="overflow", operation="toNumber", value="1606938044258990275541962092341162602522202993782792835301376", code=NUMERIC_FAULT, version=bignumber/5.5.0)

Call Stack
Logger.makeError
node_modules/@ethersproject/logger/lib.esm/index.js (185:0)
Logger.throwError
node_modules/@ethersproject/logger/lib.esm/index.js (194:0)
throwFault
node_modules/@ethersproject/bignumber/lib.esm/bignumber.js (296:0)
BigNumber.toNumber
node_modules/@ethersproject/bignumber/lib.esm/bignumber.js (146:0)
ArrayCoder.decode
node_modules/@ethersproject/abi/lib.esm/coders/array.js (189:0)
eval
node_modules/@ethersproject/abi/lib.esm/coders/array.js (76:0)
Array.forEach
<anonymous>
unpack
node_modules/@ethersproject/abi/lib.esm/coders/array.js (70:0)
TupleCoder.decode
node_modules/@ethersproject/abi/lib.esm/coders/tuple.js (54:46)
AbiCoder.decode
node_modules/@ethersproject/abi/lib.esm/abi-coder.js (93:0)
Interface.decodeFunctionResult
node_modules/@ethersproject/abi/lib.esm/interface.js (312:0)
Contract.eval
node_modules/@ethersproject/contracts/lib.esm/index.js (288:0)
Generator.next
<anonymous>
fulfilled
node_modules/@ethersproject/contracts/lib.esm/index.js (5:42)

If I take away some of the output arrays it works. All i'm doing on the react side is calling the method on the contract (all the other method calls work fine) and when I inspect the object I can see each of the collections is an error similar to this.

React app deps:

  "dependencies": {
    "@ethersproject/bignumber": "^5.5.0",
    "@ethersproject/contracts": "^5.5.0",
    "@ethersproject/providers": "^5.5.0",
    "@ethersproject/units": "^5.5.0",
    "@ethersproject/wallet": "^5.5.0",
    "@metamask/detect-provider": "^1.2.0",
    "@metamask/onboarding": "^1.0.1",
    "@popperjs/core": "2.10.2",
    "@tailwindcss/forms": "0.3.4",
    "@web3-react/core": "^6.1.9",
    "@web3-react/injected-connector": "^6.0.7",
    "ethers": "^5.5.1",
    "next": "12.0.3",
    "react": "17.0.2",
    "react-dom": "17.0.2",
    "react-hook-form": "^7.19.1",
    "swr": "^1.0.1"
  },
  "devDependencies": {
    "@typechain/ethers-v5": "8.0.2",
    "@types/react": "^17.0.34",
    "autoprefixer": "^10.4.0",
    "eslint": "7.32.0",
    "eslint-config-next": "12.0.1",
    "postcss": "^8.3.11",
    "prettier": "^2.4.1",
    "tailwindcss": "^2.2.19",
    "typechain": "^6.0.2",
    "typescript": "^4.4.4"
  },

Also, splitting them into smaller view functions works as well, it seems when there are more than 6 elements to be returned it doesn't like it.

[zemse]

At some point in your react code, there must be a .toNumber() on a bignumber which is causing this issue. Javascript number can have 53 bits of precision, when your bignumber is larger than 2^53 - 1, then overflow occurs. Please refer to this section in the docs for more info. Lmk if you need any additional help.